-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: remove filter reviews by publish timestamp (#387)
Filtering the reviews by `publishedAt` is wrong, because the `committedDate` of commit is a timestamp from when the commit is created, not pushed to Github. So if the user has the commit locally for some time, and someone reviews the PR in the meanwhile, the review is not removed when the commit is pushed (because the review has a newer timestamp than the commit). The review filtering shouldn't be needed anyway, so it should be ok to remove it completely.
- Loading branch information
Showing
6 changed files
with
8 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,6 @@ const getPullRequestQuery = /* GraphQL */ ` | |
id | ||
} | ||
} | ||
publishedAt | ||
} | ||
pageInfo { | ||
hasNextPage | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters