Skip to content

Commit

Permalink
feat: upgrade node to v20 (#82)
Browse files Browse the repository at this point in the history
The node18 runner is not going to be supported by Github, and the
current Node LTS version is 18. So let's jump directly from v16 to v20,
to keep up with Node LTS.

BREAKING CHANGE: The action now runs on node20 runner. If you use
self-hosted runners, make sure you are able to run actions with node
v20.
  • Loading branch information
Balvajs authored Sep 19, 2023
1 parent ed914c5 commit da9f4f2
Show file tree
Hide file tree
Showing 8 changed files with 68 additions and 68 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set Node.js 18.x
- name: Set Node.js 20.x
uses: actions/[email protected]
with:
node-version: 18.x
node-version: 20.x

- uses: pnpm/action-setup@v2

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
with:
fetch-depth: 0

- name: Set Node.js 18.x
- name: Set Node.js 20.x
uses: actions/[email protected]
with:
node-version: 18.x
node-version: 20.x

- uses: pnpm/action-setup@v2

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ jobs:
steps:
- uses: actions/checkout@v4

- name: Set Node.js 18.x
- name: Set Node.js 20.x
uses: actions/[email protected]
with:
node-version: 18.x
node-version: 20.x

- uses: pnpm/action-setup@v2

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v20
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ inputs:
default: dismiss-all

runs:
using: 'node16'
using: 'node20'
main: 'dist/main.cjs'
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"actions"
],
"engines": {
"node": "=18"
"node": "=20"
},
"packageManager": "[email protected]",
"type": "module",
Expand All @@ -50,7 +50,7 @@
"@swc/core": "1.3.86",
"@swc/jest": "0.2.29",
"@types/jest": "29.5.5",
"@types/node": "18.17.17",
"@types/node": "20.6.2",
"@typescript-eslint/eslint-plugin": "6.7.2",
"@typescript-eslint/parser": "6.7.2",
"chalk": "5.3.0",
Expand Down
Loading

0 comments on commit da9f4f2

Please sign in to comment.