Skip to content

Commit

Permalink
Merge pull request #84 from Bandwidth/task/fix-download-recording-bug
Browse files Browse the repository at this point in the history
Bug Fix - Handle Binary Download Recording Media Response
  • Loading branch information
ajrice6713 authored Feb 13, 2023
2 parents 20a947d + 6e801a1 commit 2e69191
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,8 @@ target
*.class

tempsettings.xml
*.bin
*.lock
*.properties
*.prefs
.vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ public ApiResponse<DynamicResponse> getDownloadCallRecording(
HttpRequest request = buildGetDownloadCallRecordingRequest(accountId, callId, recordingId);
authManagers.get("voice").apply(request);

HttpResponse response = getClientInstance().execute(request, false);
HttpResponse response = getClientInstance().execute(request, true);
HttpContext context = new HttpContext(request, response);

return handleGetDownloadCallRecordingResponse(context);
Expand All @@ -1164,7 +1164,7 @@ public CompletableFuture<ApiResponse<DynamicResponse>> getDownloadCallRecordingA
recordingId),
req -> authManagers.get("voice").applyAsync(req)
.thenCompose(request -> getClientInstance()
.executeAsync(request, false)),
.executeAsync(request, true)),
context -> handleGetDownloadCallRecordingResponse(context));
}

Expand Down Expand Up @@ -3080,4 +3080,4 @@ private ApiResponse<List<CallRecordingMetadata>> handleGetQueryCallRecordingsRes
return new ApiResponse<List<CallRecordingMetadata>>(response.getStatusCode(), response.getHeaders(), result);
}

}
}

0 comments on commit 2e69191

Please sign in to comment.