Skip to content

Commit

Permalink
remove try catch
Browse files Browse the repository at this point in the history
  • Loading branch information
ckoegel committed Oct 18, 2023
1 parent 7b930b6 commit 4a4d93e
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 38 deletions.
42 changes: 19 additions & 23 deletions tests/integration/calls-api.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,29 +54,25 @@ describe('CallsApi', () => {
callbackTimeout: callbackTimeout
}

try {
const { status, data } = await callsApi.createCall(BW_ACCOUNT_ID, callBody);

expect(status).toEqual(201);
expect(data.applicationId).toEqual(BW_VOICE_APPLICATION_ID);
expect(data.accountId).toEqual(BW_ACCOUNT_ID);
expect(data.callId).toHaveLength(47);
expect(data.to).toEqual(USER_NUMBER);
expect(data.from).toEqual(BW_NUMBER);
expect(data.callTimeout).toEqual(callTimeout);
expect(data.callbackTimeout).toEqual(callbackTimeout);
expect(data.answerMethod).toEqual(answerMethod);
expect(data.answerUrl).toEqual(answerUrl);
expect(data.answerFallbackMethod).toEqual(answerFallbackMethod);
expect(data.disconnectMethod).toEqual(disconnectMethod);
expect(data.disconnectUrl).toEqual(disconnectUrl);
expect(data.priority).toEqual(priority);

callId = data.callId;
activeCalls.push(callId);
} catch (e) {
console.log(e);
}
const { status, data } = await callsApi.createCall(BW_ACCOUNT_ID, callBody);

expect(status).toEqual(201);
expect(data.applicationId).toEqual(BW_VOICE_APPLICATION_ID);
expect(data.accountId).toEqual(BW_ACCOUNT_ID);
expect(data.callId).toHaveLength(47);
expect(data.to).toEqual(USER_NUMBER);
expect(data.from).toEqual(BW_NUMBER);
expect(data.callTimeout).toEqual(callTimeout);
expect(data.callbackTimeout).toEqual(callbackTimeout);
expect(data.answerMethod).toEqual(answerMethod);
expect(data.answerUrl).toEqual(answerUrl);
expect(data.answerFallbackMethod).toEqual(answerFallbackMethod);
expect(data.disconnectMethod).toEqual(disconnectMethod);
expect(data.disconnectUrl).toEqual(disconnectUrl);
expect(data.priority).toEqual(priority);

callId = data.callId;
activeCalls.push(callId);
});
});

Expand Down
26 changes: 11 additions & 15 deletions tests/integration/messages-api.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,17 @@ describe('MessagesApi', () => {
expiration: expiration
};

try {
const { status, data } = await messagesApi.createMessage(BW_ACCOUNT_ID, messageRequest);

expect(status).toEqual(202);
expect(data.id).toHaveLength(29);
expect(data.owner).toEqual(BW_NUMBER);
expect(data.to).toEqual([USER_NUMBER]);
expect(data.from).toEqual(BW_NUMBER);
expect(data.text).toEqual(smsText);
expect(data.tag).toEqual(smsTag);
expect(data.priority).toEqual(priority);
expect(data.expiration).toEqual(expiration);
} catch (e) {
console.log(e);
}
const { status, data } = await messagesApi.createMessage(BW_ACCOUNT_ID, messageRequest);

expect(status).toEqual(202);
expect(data.id).toHaveLength(29);
expect(data.owner).toEqual(BW_NUMBER);
expect(data.to).toEqual([USER_NUMBER]);
expect(data.from).toEqual(BW_NUMBER);
expect(data.text).toEqual(smsText);
expect(data.tag).toEqual(smsTag);
expect(data.priority).toEqual(priority);
expect(data.expiration).toEqual(expiration);

});

Expand Down

0 comments on commit 4a4d93e

Please sign in to comment.