Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWI-6218 Update SDK Based on Recent Spec Changes #45

Merged
merged 4 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions bandwidth.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1862,7 +1862,6 @@ components:
- from
- text
- media
- priority
messageDeliveredCallback:
description: Message Delivered Callback
type: object
Expand Down Expand Up @@ -2035,7 +2034,6 @@ components:
- from
- text
- tag
- priority
callbackMethodEnum:
type: string
nullable: true
Expand Down
3 changes: 1 addition & 2 deletions custom_templates/tsconfig.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,5 @@
"dist",
"tests",
"node_modules"
],
"include": ["global.d.ts"]
]
}
9 changes: 5 additions & 4 deletions models/bxml/Verb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ import { XMLBuilder, XMLWriterOptions } from 'xmlbuilder2/lib/interfaces';
*/
export class Verb {
name: string;
content: string;
attributes: object;
content: string | undefined;
attributes: object | undefined;

/**
* Creates an instance of Verb
Expand All @@ -19,15 +19,16 @@ export class Verb {
*/
constructor(name: string, content?: string, attributes?: object) {
this.name = name;
this.attributes = attributes;
this.content = content;
this.attributes = attributes;
}

/**
* Generate an XML element for the verb
*/
generateXml(): XMLBuilder {
const xml = create().ele(this.name, this.attributes).txt(this.content);
const xml = create().ele(this.name, this.attributes);
if (this.content) { xml.txt(this.content); }
return xml;
}

Expand Down
2 changes: 1 addition & 1 deletion models/message-failed-callback-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export interface MessageFailedCallbackMessage {
* @type {PriorityEnum}
* @memberof MessageFailedCallbackMessage
*/
'priority': PriorityEnum;
'priority'?: PriorityEnum;
}


Expand Down
2 changes: 1 addition & 1 deletion models/message-sending-callback-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export interface MessageSendingCallbackMessage {
* @type {PriorityEnum}
* @memberof MessageSendingCallbackMessage
*/
'priority': PriorityEnum;
'priority'?: PriorityEnum;
}


Expand Down