Skip to content

Commit

Permalink
Remove unnecessary lines
Browse files Browse the repository at this point in the history
  • Loading branch information
Bartleby2718 committed May 27, 2024
1 parent ee9ac53 commit a37d644
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
20 changes: 4 additions & 16 deletions MedallionShell.Tests/GeneralTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -582,23 +582,11 @@ public void TestProcessKeepsWritingAfterOutputIsClosed()
command.StandardInput.WriteLine(new string('a', i));
}

// TODO: This used to be a workaround for https://github.com/mono/mono/issues/18279
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
command.StandardInput.Dispose();
command.Task.Wait(TimeSpan.FromSeconds(1000)).ShouldEqual(true);
command.Result.ExitCode.ShouldEqual(1);
// SampleCommand fails because it's attempt to write to Console.Out fails hard
Assert.That(command.Result.StandardError, Does.Contain("System.IO.IOException: Write fault"));
}
else
{
command.Task.IsCompleted.ShouldEqual(false);
command.Task.IsCompleted.ShouldEqual(false);

command.StandardInput.Dispose();
command.Task.Wait(TimeSpan.FromSeconds(1000)).ShouldEqual(true);
command.Result.Success.ShouldEqual(true);
}
command.StandardInput.Dispose();
command.Task.Wait(TimeSpan.FromSeconds(1000)).ShouldEqual(true);
command.Result.Success.ShouldEqual(true);
}

[Test]
Expand Down
1 change: 0 additions & 1 deletion MedallionShell.Tests/MedallionShell.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
<ProjectReference Include="..\SampleCommand\SampleCommand.csproj" />
</ItemGroup>

<!--PR Comment: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/dev/src/Microsoft.IdentityModel.Protocols/Microsoft.IdentityModel.Protocols.csproj#L29-->
<ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
<Reference Include="Microsoft.CSharp" />
<Reference Include="System.Management" />
Expand Down

0 comments on commit a37d644

Please sign in to comment.