Merge pull request #471 from BaseAdresseNationale/antoineludeau/hot-f…

…ix-undefined-cle-interop Hot fix to handle undefined legacyCommonToponymId
BaseAdresseNationale · Sep 25, 2024 · ca4db4d · ca4db4d
2 parents f705e7b + cdba1fb
commit ca4db4d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/api/consumers/export-to-exploitation-db-consumer.js b/lib/api/consumers/export-to-exploitation-db-consumer.js
@@ -251,7 +251,9 @@ export default async function exportToExploitationDB({data}) {
 
         // Format the data and calculate the fantoir code, tiles and postal code
         const pageDataWithExtraDataCalculation = pageData.map(address => calculateExtraDataForAddress(address, cog, commonToponymIDFantoirCodeMap))
-        const formatedPageDataForLegacy = pageDataWithExtraDataCalculation.map(address => formatAddressDataForLegacy(address, district, commonToponymLegacyIDCommonToponymIDMap, addressLegacyIDSet))
+        const formatedPageDataForLegacy = pageDataWithExtraDataCalculation
+          .map(address => formatAddressDataForLegacy(address, district, commonToponymLegacyIDCommonToponymIDMap, addressLegacyIDSet))
+          .filter(Boolean)
 
         // Insert the data in the temp collection
         tempAddressCollection.insertMany(formatedPageDataForLegacy, {ordered: false})

diff --git a/lib/api/consumers/format-to-legacy-helpers.js b/lib/api/consumers/format-to-legacy-helpers.js
@@ -192,6 +192,12 @@ export const formatAddressDataForLegacy = (address, district, commonToponymLegac
 
   // Ids
   const legacyCommonToponymId = commonToponymLegacyIDCommonToponymIDMap.get(mainCommonToponymID)
+  // Temporary check : if the legacy common toponym id is not found, we don't create the address
+  if (!legacyCommonToponymId) {
+    console.log(`Address ${id} not created because its common toponym (id : ${mainCommonToponymID}) does not exist on this district (id : ${districtID} - cog: ${cog})`)
+    return
+  }
+
   const legacyInteropKey = `${legacyCommonToponymId}_${String(number).padStart(5, '0')}${suffix ? `_${suffix}` : ''}`.toLowerCase()
   const legacyID = getAddressLegacyId(addressLegacyIDSet, legacyInteropKey)
   addressLegacyIDSet.add(legacyID)