Add api route for postal areas #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLoreauIGN
requested review from
nkokla,
vinsag,
antoineludeau and
IGNFBourcier
FLoreauIGN
force-pushed
the
add-api-route-for-postal-areas
branch
from
06d2369 to
4b5c11a
Compare
FLoreauIGN
force-pushed
the
add-api-route-for-postal-areas
branch
from
5ee9358 to
69aba5e
Compare
FLoreauIGN
force-pushed
the
add-api-route-for-postal-areas
branch
from
69aba5e to
cc86730
Compare
| @@ -26,6 +27,9 @@ export default async function apiConsumers({data: {dataType, jobType, data, stat | |||
| case 'district': | |||
| await districtConsumer(jobType, data, statusID) | |||
| break | |||
| case 'postalCode': | |||
There was a problem hiding this comment.
postalCode ou postalArea ? Dans l'envoi du job par l'api, c'est postalArea qui est utilisé
Comment on lines
+299
to
+315
| const formatPayloadPostalAreas = async function (payload) { | ||
| const postalCodeDBResponse = await getAllPostalAreas() || [] | ||
| const postalCodesFromDB = new Set(postalCodeDBResponse.map(({postalCode}) => postalCode)) | ||
|
|
||
| const {features, crs} = payload || {} | ||
|
|
||
| const bulkOperations = features.map(({properties, geometry}) => { | ||
| const postalCode = properties.cp | ||
| postalCodesFromDB.delete(postalCode) | ||
| if (geometry.crs === undefined) { | ||
| geometry.crs = crs | ||
| } | ||
|
|
||
| return {postalCode, geometry} | ||
| }) | ||
|
|
||
| return {operations: bulkOperations, expiredPostalAreas: postalCodesFromDB} |
There was a problem hiding this comment.
à mettre dans un fichier utils ?
| const statusID = nanoid() | ||
|
|
||
| await apiQueue.add( | ||
| {dataType: 'postalArea', jobType: 'update', data: postalAreas, statusID}, |
There was a problem hiding this comment.
ici on utilise postalArea et dans le consumer, on utilise postalCode
| @@ -0,0 +1,15 @@ | |||
| import {PostalArea} from '../../util/sequelize.js' | |||
|
|
|||
| export const getAllPostalAreas = () => PostalArea.findAll({attributes: ['postalCode']}) | |||
There was a problem hiding this comment.
Ici la fonction s'appelle getAllPostalAreas mais on ne récupère que les postalCode des getAllPostalAreas.
|
|
||
| export const getAllPostalAreas = () => PostalArea.findAll({attributes: ['postalCode']}) | ||
|
|
||
| export const putPostalAreas = postalAreas => PostalArea.bulkCreate(postalAreas, {updateOnDuplicate: ['geometry'], subQuery: false}) |
There was a problem hiding this comment.
Nom de fonction avec 'put' alors que l'on fait de la création.
| postalCodes.map(postalCode => PostalArea.destroy({where: {postalCode}})) | ||
| } | ||
|
|
||
| export const updatePostalAreas = async ({operations, expiredPostalAreas}) => { |
There was a problem hiding this comment.
Peut-être trouvé un autre nom pour cette fonction aussi car on ne fait pas des updates mais des créations et suppressions.
jbouhadoun
force-pushed
the
add-api-route-for-postal-areas
branch
from
319fe1c to
cc86730
Compare
|
Cette partie a été revue avec un nouveau dev, on ferme la PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#364
Cette PR ajoute une route d'API permettant d'intégrer le fichier geojson de contours postaux fourni par La Poste dans la base de données postgres.