Create api route to update district postal code with datanova #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FLoreauIGN
requested review from
nkokla,
vinsag,
antoineludeau and
IGNFBourcier
FLoreauIGN
force-pushed
the
create-api-route-to-update-district-postal-code-with-datanova
branch
from
225cece to
b26b211
Compare
|
Comme vu ensemble, faire deux routes "PUT" :
|
FLoreauIGN
force-pushed
the
create-api-route-to-update-district-postal-code-with-datanova
branch
from
b26b211 to
8d3c42c
Compare
FLoreauIGN
force-pushed
the
create-api-route-to-update-district-postal-code-with-datanova
branch
from
8d3c42c to
2cfb46e
Compare
Comment on lines
+8
to
+11
| return bddDistrictMock | ||
| .map(district => [district.meta.insee.cog, district]) | ||
| .filter(([cog]) => districtCOGs.includes(cog)) | ||
| .map(([, district]) => district) |
There was a problem hiding this comment.
Ici, pourquoi ne pas faire un simple filter : bddDistrictMock.filter(district => districtCOGs.includes(district.meta?.insee?.cog))
|
Il manque la partie sur le déclenchement de l'export vers mongo. Qu'est ce qui est prévu pour ce cas-là ? Est-ce que l'on veut exporter tous les districts qui ont changés ou bien tous les districts de France? |
|
New PR on this topic : #444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#363
Cette PR ajoute une route d'API pour mettre à jour les codes postaux des districts de la base postgres à l'aide de la base officielle des codes postaux.