Improved api response format and homogeneity #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGNFBourcier
previously requested changes
Dec 4, 2024
|
Si c'est un formatage complet : la partie try /catch non specifique retournant des 500 générique peut aussi se refact en wrapper des fonction de route. |
antoineludeau
force-pushed
the
antoineludeau/clean-api-response
branch
2 times, most recently
from
59e30f0 to
9a2dc9b
Compare
IGNFBourcier
reviewed
Dec 6, 2024
antoineludeau
force-pushed
the
antoineludeau/clean-api-response
branch
from
9a2dc9b to
f681685
Compare
antoineludeau
force-pushed
the
antoineludeau/clean-api-response
branch
from
f681685 to
8db18cc
Compare
jbouhadoun
approved these changes
Dec 10, 2024
antoineludeau
added a commit
that referenced
this pull request
Dec 10, 2024
…t-structure-change-on-api-response Revert "Merge pull request #495"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement
In order to have homogeneous api responses, this PR adds a :