Added labels from bal lieudit_complement_nom on address schema #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkokla
approved these changes
Sep 26, 2023
| @@ -51,6 +53,7 @@ export type BanAddress = { | |||
| secondaryCommonToponymIDs?: BanCommonTopoID[]; // identifiant unique des toponymes secondaires | |||
| number: number; // numéro de l'adresse | |||
| suffix?: string; | |||
| labels?: Label[]; | |||
There was a problem hiding this comment.
J'ai l'impression que labels devrait toujours être un tableau, même s'il est vide.
Tu en penses quoi ?
There was a problem hiding this comment.
À rediscuter et si besoin, à modifier dans une autre PR (à mettre en parallèle avec le champ "geometry" des toponymes communs qui est aussi optionnel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following PR and has to wait for its validation : BaseAdresseNationale/ban-plateforme#263
I. Context :
The field
lieudit_complement_nomis currently not handled is the ID-Fix BAL processing.II. Enhancements :
This PR aims to handle the
lieudit_complement_nomby adding alabelsfield to the addresses, conform to the BAN-ID data schemas on addressesIII. How to test :
1- Download a BAL (csv) and make sure at least one of the address has a lieudit_complement_nom. If not, add it manually in the CSV and save it.
2- Use the initBALIntoBAN script on ID-Fix to push your BAL into the BAN.
3- Go in the PostgreSQL DB, on Addresses table and look for the address(es) that has(have) the lieudit_complement_nom.
4- Verify that the "labels" column is filled with the correct data.
III. Additional information