Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additionalValues from uid_adresse #91

Merged
merged 1 commit into from
Apr 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/schema/error-labels.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ module.exports = {
"cle_interop.voie_non_renseignee":
"La partie voie de la clé d’interopératibilité a été laissée à nul (0000 ou xxxx)",

// uid_adresse
"uid_adresse.type_invalide": "La valeur de uid_adresse n’est pas valide",
"uid_adresse.incoherence_ids_ban":
"Les ids ban renseignés ne sont pas cohérents",

// id_ban_commune
"id_ban_commune.type_invalide":
"La valeur de id_ban_commune n’est pas un uuidv4 valide",
Expand Down
53 changes: 51 additions & 2 deletions lib/schema/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,55 @@ exports.fields = {
trim: true,
formats: ["1.1", "1.2", "1.3"],
aliases: ["uid_adress"],
parse(v, { addError, setAdditionnalValues }) {
const regUuidCommune =
/@c([A-F\d]{8}-[A-F\d]{4}-4[A-F\d]{3}-[89AB][A-F\d]{3}-[A-F\d]{12})/gi;
const regUuidToponyme =
/@v[A-F\d]{8}-[A-F\d]{4}-4[A-F\d]{3}-[89AB][A-F\d]{3}-[A-F\d]{12}/gi;
const regUuidAdresse =
/@a[A-F\d]{8}-[A-F\d]{4}-4[A-F\d]{3}-[89AB][A-F\d]{3}-[A-F\d]{12}/gi;

const [uuidCommune] = v.match(regUuidCommune) || [];
const [uuidToponyme] = v.match(regUuidToponyme) || [];
const [uuidAdresse] = v.match(regUuidAdresse) || [];

const idBanCommune = uuidCommune?.substr(2) || null;
const idBanToponyme = uuidToponyme?.substr(2) || null;
const idBanAdresse = uuidAdresse?.substr(2) || null;

if (
!isUuid(idBanCommune) ||
!isUuid(idBanToponyme) ||
idBanAdresse === null ||
!isUuid(idBanAdresse)
) {
return addError("type_invalide");
}

if (!idBanCommune || !idBanToponyme) {
addError("incoherence_ids_ban");
}

// LES IDS id_ban_commune / id_ban_toponyme / id_ban_adresse NE PEUVENT PAS ËTRE IDENTIQUES
if (
(idBanCommune && idBanToponyme && idBanCommune === idBanToponyme) ||
(idBanCommune && idBanAdresse && idBanCommune === idBanAdresse) ||
(idBanAdresse && idBanToponyme && idBanToponyme === idBanAdresse)
) {
addError("incoherence_ids_ban");
}

// SI IL Y A UN id_ban_toponyme, IL Y A UN id_ban_commune
// SI IL Y A UN id_ban_adresse, IL Y A UN id_ban_toponyme ET DONC IL Y A IL Y A UN id_ban_commune

setAdditionnalValues({
idBanCommune,
idBanToponyme,
idBanAdresse,
});

return v;
},
},

id_ban_commune: {
Expand Down Expand Up @@ -380,7 +429,7 @@ exports.fields = {
}

return parcelles.map((p) =>
p.length === 14 ? p : p.slice(0, 2) + p.slice(3),
p.length === 14 ? p : p.slice(0, 2) + p.slice(3)
);
},
},
Expand Down Expand Up @@ -481,7 +530,7 @@ function validateCoords(row, { addError }) {
if (x !== undefined && y !== undefined) {
const distance = Math.sqrt(
(x - projectedCoordInMeters[0]) ** 2 +
(y - projectedCoordInMeters[1]) ** 2,
(y - projectedCoordInMeters[1]) ** 2
);
const tolerance = 10;

Expand Down
3 changes: 3 additions & 0 deletions lib/schema/profiles/1.3-relax.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ const warnings = [
"cad_parcelles.espaces_debut_fin",
"source.espaces_debut_fin",
"date_der_maj.espaces_debut_fin",
// ID BAN
"uid_adresse.type_invalide",
"uid_adresse.incoherence_ids_ban",
];

const infos = ["cle_interop.voie_non_renseignee"];
Expand Down
2 changes: 1 addition & 1 deletion lib/schema/profiles/1.3-strict.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ const warnings = ["position.enum_fuzzy"];
module.exports = {
code: "1.3-strict",
name: "BAL 1.3 Strict",
isUsed: true,
isUsed: false,
relax: false,
errors,
warnings,
Expand Down
3 changes: 3 additions & 0 deletions lib/schema/profiles/1.3.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ const warnings = [
"cad_parcelles.espaces_debut_fin",
"source.espaces_debut_fin",
"date_der_maj.espaces_debut_fin",
// ID BAN
"uid_adresse.type_invalide",
"uid_adresse.incoherence_ids_ban",
];

const infos = ["cle_interop.voie_non_renseignee"];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,58 +2,37 @@ const errors = [
"cle_interop.structure_invalide",
"cle_interop.commune_invalide",
"cle_interop.numero_invalide",
"cle_interop.valeur_manquante",
"cle_interop.numero_prefixe_manquant",
"cle_interop.casse_invalide",
"voie_nom.valeur_manquante",
"voie_nom.trop_court",
"voie_nom.trop_long",
"voie_nom.caractere_invalide",
"numero.valeur_manquante",
"numero.type_invalide",
"numero.trop_grand",
"numero.contient_prefixe",
"suffixe.debut_invalide",
"suffixe.trop_long",
"date_der_maj.date_invalide",
"commune_insee.commune_invalide",
"commune_insee.valeur_manquante",
"commune_insee.espaces_debut_fin",
"x.valeur_invalide",
"y.valeur_invalide",
"x.separateur_decimal_invalide",
"y.separateur_decimal_invalide",
"long.valeur_invalide",
"lat.valeur_invalide",
"long.separateur_decimal_invalide",
"lat.separateur_decimal_invalide",
"row.incoherence_numero",
"row.commune_manquante",
"row.longlat_vides",
"row.longlat_invalides",
"row.adresse_incomplete",
"field.commune_insee.missing",
"field.voie_nom.missing",
"field.numero.missing",
"field.commune_nom.long",
"field.commune_nom.lat",
"suffixe.espaces_debut_fin",
"file.encoding.non_standard",
"file.delimiter.non_standard",
"file.linebreak.non_standard",
"rows.empty",

"id_ban_commune.type_invalide",
"id_ban_toponyme.type_invalide",
"id_ban_adresse.type_invalide",
"row.incoherence_ids_ban",
"row.id_ban_adresses_required",
"rows.ids_required_every",
];

const warnings = [
"cle_interop.valeur_manquante",
"cle_interop.casse_invalide",
"cle_interop.voie_invalide",
"cle_interop.numero_prefixe_manquant",
"cle_interop.commune_ancienne",
"numero.contient_prefixe",
"voie_nom.casse_incorrecte",
"voie_nom.contient_tiret_bas",
"voie_nom_@@.casse_incorrecte",
Expand All @@ -67,10 +46,15 @@ const warnings = [
"commune_deleguee_insee.commune_ancienne_non_deleguee",
"position.enum_fuzzy",
"position.valeur_invalide",
"x.separateur_decimal_invalide",
"y.separateur_decimal_invalide",
"long.separateur_decimal_invalide",
"lat.separateur_decimal_invalide",
"cad_parcelles.valeur_invalide",
"cad_parcelles.pipe_debut_fin",
"source.valeur_manquante",
"date_der_maj.valeur_manquante",
"date_der_maj.date_invalide",
"date_der_maj.date_ancienne",
"date_der_maj.date_future",
"certification_commune.valeur_invalide",
Expand All @@ -79,6 +63,7 @@ const warnings = [
"row.longlat_xy_incoherents",
"field.suffixe.missing",
"field.cle_interop.missing",
"field.commune_insee.missing",
"field.position.missing",
"field.long.missing",
"field.lat.missing",
Expand All @@ -89,6 +74,7 @@ const warnings = [
"field.certification_commune.missing",

"cle_interop.espaces_debut_fin",
"commune_insee.espaces_debut_fin",
"commune_nom.espaces_debut_fin",
"commune_deleguee_insee.espaces_debut_fin",
"commune_deleguee_nom.espaces_debut_fin",
Expand All @@ -98,6 +84,7 @@ const warnings = [
"lieudit_complement_nom.espaces_debut_fin",
"lieudit_complement_nom_@@.espaces_debut_fin",
"numero.espaces_debut_fin",
"suffixe.espaces_debut_fin",
"position.espaces_debut_fin",
"long.espaces_debut_fin",
"lat.espaces_debut_fin",
Expand All @@ -110,15 +97,23 @@ const warnings = [
"field.id_ban_commune.missing",
"field.id_ban_toponyme.missing",
"field.id_ban_adresse.missing",
"id_ban_commune.type_invalide",
"id_ban_toponyme.type_invalide",
"id_ban_adresse.type_invalide",
"row.incoherence_ids_ban",
"row.id_ban_adresses_required",
"rows.ids_required_every",
"uid_adresse.type_invalide",
"uid_adresse.incoherence_ids_ban",
];

const infos = ["cle_interop.voie_non_renseignee"];

module.exports = {
code: "1.4-strict",
name: "BAL 1.4 Strict (beta)",
isUsed: true,
relax: false,
code: "1.4-relax",
name: "BAL 1.4 Relax (beta)",
isUsed: false,
relax: true,
errors,
warnings,
infos,
Expand Down
47 changes: 28 additions & 19 deletions lib/schema/profiles/1.4.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,58 @@ const errors = [
"cle_interop.structure_invalide",
"cle_interop.commune_invalide",
"cle_interop.numero_invalide",
"cle_interop.valeur_manquante",
"cle_interop.numero_prefixe_manquant",
"cle_interop.casse_invalide",
"voie_nom.valeur_manquante",
"voie_nom.trop_court",
"voie_nom.trop_long",
"voie_nom.caractere_invalide",
"numero.valeur_manquante",
"numero.type_invalide",
"numero.trop_grand",
"numero.contient_prefixe",
"suffixe.debut_invalide",
"suffixe.trop_long",
"date_der_maj.date_invalide",
"commune_insee.commune_invalide",
"commune_insee.valeur_manquante",
"commune_insee.espaces_debut_fin",
"x.valeur_invalide",
"y.valeur_invalide",
"x.separateur_decimal_invalide",
"y.separateur_decimal_invalide",
"long.valeur_invalide",
"lat.valeur_invalide",
"long.separateur_decimal_invalide",
"lat.separateur_decimal_invalide",
"row.incoherence_numero",
"row.commune_manquante",
"row.longlat_vides",
"row.longlat_invalides",
"row.adresse_incomplete",
"field.commune_insee.missing",
"field.voie_nom.missing",
"field.numero.missing",
"field.commune_nom.long",
"field.commune_nom.lat",
"suffixe.espaces_debut_fin",
"file.encoding.non_standard",
"file.delimiter.non_standard",
"file.linebreak.non_standard",
"rows.empty",

"id_ban_commune.type_invalide",
"id_ban_toponyme.type_invalide",
"id_ban_adresse.type_invalide",
"row.incoherence_ids_ban",
"row.id_ban_adresses_required",
"rows.ids_required_every",
];

const warnings = [
"cle_interop.valeur_manquante",
"cle_interop.casse_invalide",
"cle_interop.voie_invalide",
"cle_interop.numero_prefixe_manquant",
"cle_interop.commune_ancienne",
"numero.contient_prefixe",
"voie_nom.casse_incorrecte",
"voie_nom.contient_tiret_bas",
"voie_nom_@@.casse_incorrecte",
Expand All @@ -46,15 +67,10 @@ const warnings = [
"commune_deleguee_insee.commune_ancienne_non_deleguee",
"position.enum_fuzzy",
"position.valeur_invalide",
"x.separateur_decimal_invalide",
"y.separateur_decimal_invalide",
"long.separateur_decimal_invalide",
"lat.separateur_decimal_invalide",
"cad_parcelles.valeur_invalide",
"cad_parcelles.pipe_debut_fin",
"source.valeur_manquante",
"date_der_maj.valeur_manquante",
"date_der_maj.date_invalide",
"date_der_maj.date_ancienne",
"date_der_maj.date_future",
"certification_commune.valeur_invalide",
Expand All @@ -63,7 +79,6 @@ const warnings = [
"row.longlat_xy_incoherents",
"field.suffixe.missing",
"field.cle_interop.missing",
"field.commune_insee.missing",
"field.position.missing",
"field.long.missing",
"field.lat.missing",
Expand All @@ -74,7 +89,6 @@ const warnings = [
"field.certification_commune.missing",

"cle_interop.espaces_debut_fin",
"commune_insee.espaces_debut_fin",
"commune_nom.espaces_debut_fin",
"commune_deleguee_insee.espaces_debut_fin",
"commune_deleguee_nom.espaces_debut_fin",
Expand All @@ -84,7 +98,6 @@ const warnings = [
"lieudit_complement_nom.espaces_debut_fin",
"lieudit_complement_nom_@@.espaces_debut_fin",
"numero.espaces_debut_fin",
"suffixe.espaces_debut_fin",
"position.espaces_debut_fin",
"long.espaces_debut_fin",
"lat.espaces_debut_fin",
Expand All @@ -97,20 +110,16 @@ const warnings = [
"field.id_ban_commune.missing",
"field.id_ban_toponyme.missing",
"field.id_ban_adresse.missing",
"id_ban_commune.type_invalide",
"id_ban_toponyme.type_invalide",
"id_ban_adresse.type_invalide",
"row.incoherence_ids_ban",
"row.id_ban_adresses_required",
"rows.ids_required_every",
"uid_adresse.type_invalide",
"uid_adresse.incoherence_ids_ban",
];

const infos = ["cle_interop.voie_non_renseignee"];

module.exports = {
code: "1.4",
name: "BAL 1.4 (beta)",
isUsed: false,
isUsed: true,
relax: false,
errors,
warnings,
Expand Down
2 changes: 1 addition & 1 deletion lib/schema/profiles/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
const profiles = {
1.4: require("./1.4"),
"1.4-strict": require("./1.4-strict"),
"1.4-relax": require("./1.4-relax"),
1.3: require("./1.3"),
"1.3-relax": require("./1.3-relax"),
"1.3-strict": require("./1.3-strict"),
Expand Down
2 changes: 2 additions & 0 deletions lib/validate/__tests__/1.4/data/1.3-valid-uid_adresse.csv
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
cle_interop;uid_adresse;commune_insee;voie_nom;numero;suffixe;commune_nom;position;long;lat;x;y;source;date_der_maj
31591_xxxx_00009;@c0246e48c-f33d-433a-8984-034219be842e @v8a3bab10-f329-4ce3-9c7d-280d91a8053a @a3c87abe4-887b-46ee-9192-5c1b35a06625;31591;Rue des 3 Places;9;;Escoulis;entrée;1.028392;43.111637;539416.13;6225601.11;;2020-11-09
Loading
Loading