Fix some bugs

Baseflow · Aug 11, 2020 · 004920c · 004920c
1 parent 1c13770
commit 004920c
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 3 deletions.
diff --git a/MediaManager/Library/IMediaItem.cs b/MediaManager/Library/IMediaItem.cs
@@ -186,5 +186,10 @@ public interface IMediaItem : IContentItem
         /// Standard location is Default which will make a guess based on the URI.
         /// </summary>
         MediaLocation MediaLocation { get; set; }
+
+        /// <summary>
+        /// Indicates if the MediaItem is being live streamed
+        /// </summary>
+        bool IsLive { get; set; }
     }
 }
diff --git a/MediaManager/Library/MediaItem.cs b/MediaManager/Library/MediaItem.cs
@@ -328,5 +328,12 @@ public bool IsMetadataExtracted
                     MetadataUpdated?.Invoke(this, new MetadataChangedEventArgs(this));
             }
         }
+
+        private bool _isLive = false;
+        public bool IsLive
+        {
+            get => _isLive;
+            set => SetProperty(ref _isLive, value);
+        }
     }
 }
diff --git a/MediaManager/Platforms/Android/MediaSession/MediaBrowserService.cs b/MediaManager/Platforms/Android/MediaSession/MediaBrowserService.cs
@@ -129,8 +129,7 @@ protected virtual void PrepareNotificationManager()
             };
             NotificationListener.OnNotificationCancelledImpl = (notificationId, dismissedByUser) =>
             {
-                //TODO: in new exoplayer use StopForeground(false) or use dismissedByUser
-                StopForeground(true);
+                StopForeground(dismissedByUser);
                 //ServiceCompat.StopForeground(this, ServiceCompat.StopForegroundRemove);
 
                 StopSelf();

diff --git a/MediaManager/Platforms/Android/Player/AndroidMediaPlayer.cs b/MediaManager/Platforms/Android/Player/AndroidMediaPlayer.cs
@@ -233,6 +233,14 @@ protected virtual void Initialize()
                 {
                     if (isLoading)
                         MediaManager.Buffered = TimeSpan.FromMilliseconds(Player.BufferedPosition);
+                },
+                OnIsPlayingChangedImpl = (bool isPlaying) =>
+                {
+                    //TODO: Maybe call playing changed event
+                },
+                OnPlaybackSuppressionReasonChangedImpl = (int playbackSuppressionReason) =>
+                {
+                    //TODO: Maybe call event
                 }
             };
             Player.AddListener(PlayerEventListener);

diff --git a/MediaManager/Platforms/Apple/Notifications/NotificationManager.cs b/MediaManager/Platforms/Apple/Notifications/NotificationManager.cs
@@ -135,7 +135,8 @@ public override void UpdateNotification()
                 ElapsedPlaybackTime = MediaManager.Position.TotalSeconds,
                 PlaybackDuration = MediaManager.Duration.TotalSeconds,
                 PlaybackQueueIndex = MediaManager.Queue.CurrentIndex,
-                PlaybackQueueCount = MediaManager.Queue.Count
+                PlaybackQueueCount = MediaManager.Queue.Count,
+                IsLiveStream = mediaItem.IsLive
             };
 
             if (MediaManager.IsPlaying())