Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change order to allow to override ifNoneMatchHeader #463

Merged

Conversation

binSaed
Copy link
Contributor

@binSaed binSaed commented Jul 23, 2024

✨ What kind of change does this PR introduce?

feature

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

The user can't override etag

💥 Does this PR introduce a breaking change?

no

🐛 Recommendations for testing

no

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@binSaed
Copy link
Contributor Author

binSaed commented Jul 23, 2024

currently, in some cases, we generate eTag on the mobile side

Screenshot 2024-07-23 at 12 53 45 PM

@martijn00 martijn00 force-pushed the feature/override--ifNoneMatchHeader branch from c8f851f to 6be3abf Compare July 31, 2024 20:28
@martijn00 martijn00 merged commit 0f05da6 into Baseflow:develop Jul 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants