Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio/x-wav as wav, fix typo for midi #466

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

XMitja
Copy link
Contributor

@XMitja XMitja commented Aug 8, 2024

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

bug fix

⤵️ What is the current behavior?

if a web server returns mime type audio/x-wav for a file, you end up with suffix .x-wav, preventing automatic playback with for example AVPlayer

the line for midi and x-midi was just obviously wrong

🆕 What is the new behavior (if this is a feature change)?

audio/x-wav and x-midi files will play correctly

💥 Does this PR introduce a breaking change?

no

@martijn00 martijn00 merged commit 8f2fade into Baseflow:develop Aug 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants