Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket is null because of variable shadowing #468

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

minhdanh
Copy link
Contributor

@minhdanh minhdanh commented Sep 12, 2024

✨ What kind of change does this PR introduce? In recent version of Dart/Flutter (3.5.1/3.24.2), the bucket is null even when it is assigned.

⤵️ What is the current behavior?

Bucket is null even when the value is passed

🆕 What is the new behavior (if this is a feature change)?

Make sure the bucket is not null when it is passed at inititalization

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@martijn00 martijn00 merged commit 3d18fcf into Baseflow:develop Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants