Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch the usages of DecoderCallback. #875

Closed
wants to merge 1 commit into from

Conversation

xclud
Copy link

@xclud xclud commented Sep 9, 2023

Newer versions of Flutter have removed the DecoderCallback typedef. Hence it is replaced with Future<ui.Codec> Function(Uint8List).

@chengen
Copy link

chengen commented Sep 17, 2023

Great job, waiting for release

@CrisNegoianu
Copy link

Thank you for this change.
Please release this as we can't upgrade to the latest flutter version without it.

@mustansirgodhrawala
Copy link

Please expedite the release of these changes we need them

@PlayCulture
Copy link

Thank you for addressing the change - also waiting on this one :0)

@xclud
Copy link
Author

xclud commented Sep 25, 2023

Meanwhile this PR is merged you guys can override the dependency resolving for your projects:

In pubspec.yaml add this after dependencies:.

dependency_overrides:
  cached_network_image_platform_interface:
    git:
      url: https://github.com/xclud/flutter_cached_network_image.git
      ref: fix-build-errors
      path: cached_network_image_platform_interface
  cached_network_image_web:
    git:
      url: https://github.com/xclud/flutter_cached_network_image.git
      ref: fix-build-errors
      path: cached_network_image_web
  cached_network_image:
    git:
      url: https://github.com/xclud/flutter_cached_network_image.git
      ref: fix-build-errors
      path: cached_network_image

And if you have flutter_blurhash as a dependency:

  flutter_blurhash:
    git:
      url: https://github.com/xclud/flutter_blurhash.git
      ref: fix-build-errors

@supposedlysam-bb
Copy link

Apparently it's been fixed in 3.3.0?
#877 (comment)

@PlayCulture
Copy link

Can confirm now fixed for me - big thanks!

@martijn00
Copy link
Member

This is fixed in #861 i think? Can you confirm @xclud ?

@xclud
Copy link
Author

xclud commented Oct 13, 2023

@martijn00 Yes fixed. Thanks. Closing.

@xclud xclud closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants