Fix SSH completion to preserve @ sign in user@host format #2351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SSH completion was removing the @ sign when completing user@host combinations. For example, `ssh root@ser<TAB>` would complete to `ssh rootserver` instead of `ssh root@server`. **Root Cause:** The @ character was in COMP_WORDBREAKS, causing bash to treat it as a word boundary and remove it during completion. **Solution:** Remove @ from COMP_WORDBREAKS (in addition to : which was already removed). This allows the completion to preserve the full user@host format. **Testing:** - Passes shellcheck with no warnings - Passes shfmt formatting checks - Completion now correctly preserves user@host format Closes Bash-it#2260 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
seefood
added a commit
that referenced
this pull request
Oct 7, 2025
Updated all three planning documents to reflect the completed work: **Issues Fixed (6 total)**: - #2317: Auto-detect git remote (PR #2345) - #2248: Laravel artisan completion (PR #2349) - #2296: down4me URL malformation (PR #2350) - #2260: SSH completion @ sign (PR #2351) - #2238: Uninstall script backup (PR #2352) - #2216: Node version conditional display (PR #2353) **Changes to docs/plans/**: 1. bash-it-issues-comprehensive-analysis.md - Marked 5 quick wins as FIXED with PR numbers - Updated executive summary: 32 → 27 open issues - Updated work plan to show Phase 1 completed - Updated issue reference appendix 2. bash-it-quick-reference.md - Moved completed issues to "Fixed" section - Updated TL;DR metrics - Removed completed items from decision list - Updated metrics table with current progress 3. bash-it-roadmap-2025.md - Updated health metrics (32 → 27 issues) - Marked Phase 1 as COMPLETED - Listed all 6 PRs with dates - Updated success criteria checkmarks **Remaining Work**: - 1 quick fix (#2314 - todo alias rename) - 18 stale issues to close - 4 strategic decisions needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
akinomyoga
reviewed
Oct 7, 2025
Use character class syntax [:@] to remove both characters in one operation as suggested by @akinomyoga in review. Co-Authored-By: akinomyoga <[email protected]>
* master: Fix symlink handling in uninstall backup Update planning docs with completed issues and PRs Improve uninstall script to preserve current config before restoration Fix down4me function URL malformation issue Apply review feedback: use git --git-dir and simplify awk Add comprehensive issue analysis and 2025 roadmap documentation Fix remote name detection function Add heuristic for finding default remote name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SSH completion to preserve the @ sign when completing user@host combinations.
Problem
When typing
ssh root@ser<TAB>, the completion would incorrectly produce:Instead of the expected:
Root Cause
The @ character was in
COMP_WORDBREAKS, causing bash to treat it as a word boundary and strip it during completion.Solution
Remove @ from
COMP_WORDBREAKS(in addition to:which was already removed).Changes:
This allows completion to preserve the full
user@hostformat for:Testing
Related
Closes #2260
🤖 Generated with Claude Code