Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Crypto,Did): implement rest of did:key #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(Crypto,Did): implement rest of did:key #169

wants to merge 2 commits into from

Conversation

TheButlah
Copy link
Contributor

@TheButlah TheButlah commented Mar 3, 2025 •
edited
Loading

Implements everything remaining in did:key, including:

  • signing ed25519 cryptography + tests
  • Converting from a pubkey to a did:key
  • Sample server/client code as a test case in ServerExample.cs
  • added the Generator.Equals package from nuget and made all records use value equality
  • fixed a bug in GetAlgorithm
  • Updated unity project to have correct dependencies and settings

@TheButlah TheButlah changed the base branch from lts to main March 3, 2025 05:29
@TheButlah TheButlah force-pushed the thebutlah/implement-sig-signing branch from 92fd165 to 83d6d09 Compare March 3, 2025 05:35
@TheButlah TheButlah marked this pull request as ready for review March 3, 2025 05:42
@TheButlah TheButlah requested a review from dooly123 March 3, 2025 05:45
@TheButlah TheButlah force-pushed the thebutlah/implement-sig-signing branch 2 times, most recently from 3543454 to a0c60d9 Compare March 3, 2025 06:15
@TheButlah TheButlah marked this pull request as draft March 3, 2025 09:22
@TheButlah
Copy link
Contributor Author

marking as a draft till I can finish my example test case

@TheButlah TheButlah marked this pull request as ready for review March 3, 2025 10:11
@TheButlah TheButlah force-pushed the thebutlah/implement-sig-signing branch from 7543920 to c36a25c Compare March 3, 2025 10:12
@TheButlah TheButlah changed the title feat(Crypto): implement ed25519 signature signing feat(Crypto): implement rest of did:key Mar 3, 2025
@TheButlah TheButlah changed the title feat(Crypto): implement rest of did:key feat(Crypto,Did): implement rest of did:key Mar 3, 2025
@TheButlah TheButlah force-pushed the thebutlah/implement-sig-signing branch from c36a25c to e7e6795 Compare March 3, 2025 10:16
@TheButlah TheButlah force-pushed the thebutlah/implement-sig-signing branch from e7e6795 to 9f8dbcb Compare March 3, 2025 10:19
@TheButlah
Copy link
Contributor Author

ready to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dooly123 dooly123 Awaiting requested review from dooly123

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TheButlah