Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 impr(infra) PLAS-074: Burnt Useless Code and Files #62

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

bvelitchkine
Copy link
Member

Context

Simply removed all that's useless. Doing so, I came up with this issue: #61 (to tackle post release if you agree).

Priority

Average

@bvelitchkine bvelitchkine added improvement Improvement of smthg that already existed infra Scope is infrastructure labels Nov 10, 2023
@bvelitchkine bvelitchkine self-assigned this Nov 10, 2023
Copy link
Contributor

@GauvainThery GauvainThery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

I agree that the component folder isn't ok but don't agree with your suggestion on the ticket you created, but let's move the conversation there

@bvelitchkine bvelitchkine merged commit 38fd711 into master Nov 11, 2023
1 check passed
@bvelitchkine bvelitchkine deleted the PLAS-74-burn-useless-code branch November 11, 2023 15:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement of smthg that already existed infra Scope is infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants