[UPDATE] New Rewrite [UPDATE] - please test and report bugs

[tschettervictor]

Greetings.

This is quite a big PR, as you can tell. Here are the notable changes.

• NEW etcupdate subcommand
• NEW RDR handling See RDR Improvements: Allow TO/FROM+INTERACE+IP STACK #765
• NEW jail autocomplete (type the first few letters of the jail eg next for nextcloud)
• NEW run commands on select jails by quoting them together like "jail1 jail2 jail3"
• NEW add/remove interfaces from targeted jails
• NEW inherit and ip_hostname modes for classic jails

This is a brief list, but feel free to ask questions.

I'm not sure how much the developers of this will appreciate what I did, but its working for me.
I've run through each command 3-4 times now, fixing any bugs and trying to maintain style, functionality, and similarity between each scripts.

Any and all changes had good reasons, just ask, and I can give them.

I would like if this could somehow be introduced as a beta branch so folks could download "pkg install bastille-devel" or something similar.

This is of course not my decision, so I'm willing to accept any criticism and questions.

There may be more bugs and issues present, and I want to get as much testing in as possible. Basic usage works great, and I couldn't find much more to correct and check, so give it a go in a testing environment.

PS, there will be more commits if I find more bugs or improvements that can be added.

[tschettervictor]

Is there any way we could get this into a beta version?
Code is pretty clean as I can see it.

All it needs now is for people to go about testing it as much as they can.

[bmac2]

this one is failing the shellcheck test

[bmac2]

I prefer one change per pr. If the PR is too big it is too easy for the testing to miss stuff. I am trying to get all the older PRs tested and in as I can. having the ability to chat with you on either discord, telegram or IRC, all of which we have channels on and I am in them all would speed this up in getting all of these tested and merged.

[tschettervictor]

This PR brings a ton with it.

RDR improvements

Mount Improvements like mounting directories with spaces, and mounting files

Overall better function structure and error handling.

Most of the bugs in the Issues section should be worked out (at least the ones that were straightforward)

I would still like to get this out in beta, so we can at least get it easier to install through pkg. We all agree that the current structure is a little bit messy (which is ok if it works)

[tschettervictor]

I think I've finally added just about all I can think to add based on the bug reports for now. There might be some cosmetic fixes and bug fixes.

I'm going to leave this PR in place as it will be my base for future PRs.