Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repaired git #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Repaired git #12

wants to merge 5 commits into from

Conversation

donkeybridge
Copy link

Hi there,
while trying to use rocinante I found first that the git repo is pulled into /usr/local/rocinante/templates instead of /usr/local/rocinante/templates/user/repository, so I fixed this.

Further I found, that there is no check whether any new commits have been done to origin although a pull mechanism is found in bootstrap.sh. So I implemented this check triggering another call to bootstrap if the local repo is behind origin.

I am not very familar with git, but still if I am able to dive deeper I would send another suggestion to set a custom name for the deployment branch used, instead of the generic master.

Hope you'll find these 2 cents helpful :)

KR
Benjamin

Bennie added 5 commits February 14, 2023 22:30
…ling git remote -- from ${rocinante_templatesdir} to ${_template}

bootstrap.sh: Also added "mkdir -p ${_template}" to ensure it exists
template.sh: Added git remote check if LOCAL_REPO is behind master -- and if so, use bootstrap.sh for pulling updates
…nching parameter in template.sh and bootstrap.sh
bootstrap.sh: added --single-branch and --branch [branch] to git clone
template.sh: added [branch] to bootstrap calls and --branches to git rev-list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant