More perf fixes: #11
Open
More perf fixes: #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BA was also using a tagset to check if it could swarm, this is now replaced with an injected field for best perf. - replaced resupply unit stats collection check with an injected field, this should further improve resupply perf. - GetAllFriendlies is doing an unneeded IsDead check because GetAllLivingActors is already doing that. Given that it returns a new list and uses a findall, I swapped this instead for using the allActors property, so we only have to do 1 iteration over the list of actors. This also saves a new list being created and reduces the number of calls of IsDead by 1 per actor per call of GetAllFriendlies, which is frequently called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BA was also using a tagset to check if it could swarm, this is now replaced with an injected field for best perf.
replaced resupply unit stats collection check with an injected field, this should further improve resupply perf.
GetAllFriendlies is doing an unneeded IsDead check because GetAllLivingActors is already doing that. Given that it returns a new list and uses a findall, I swapped this instead for using the allActors property, so we only have to do 1 iteration over the list of actors. This also saves a new list being created and reduces the number of calls of IsDead by 1 per actor per call of GetAllFriendlies, which is frequently called.