Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nolazyload tpl #429

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix nolazyload tpl #429

merged 2 commits into from
Nov 18, 2024

Conversation

cedric07
Copy link
Contributor

@cedric07 cedric07 commented Oct 14, 2024

Suite à cette PR : https://github.com/BeAPI/beapi-frontend-framework/pull/422/files

Il manquait l'ajout des fichiers de templates dans la condition pour que ça fonctionne bien

Ajout aussi d'un exemple de tpl pour le non lazyload. car ils ne s'écrivent pas pareil.

On avait uniquement un exemple pour le lazyload et pas pour l'autre

Lazyload :

<source data-srcset="%%img-100-100%%, %%img-200-200%% 2x" media="(max-width: 768px)" %%srcset%% />
<source data-srcset="%%img-200-200%%, %%img-400-400%% 2x" %%srcset%% />

Non lazyload (fetchpriority hight) :

<source srcset="%%img-100-100%%, %%img-200-200%% 2x" media="(max-width: 768px)" />
<source srcset="%%img-200-200%%, %%img-400-400%% 2x" />

@cedric07 cedric07 merged commit 1c503a3 into master Nov 18, 2024
2 of 3 checks passed
@cedric07 cedric07 deleted the fix/nolazyload-size branch November 18, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants