Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skip_index): possibility added to skip index actions #942

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

jorma16
Copy link
Contributor

@jorma16 jorma16 commented Jun 6, 2024

Just added the possibility to avoid index operations in init, like someone ask here: #924

And other people workaround here: #608

Please, take care of this, I really need this and I think that is very interesting for read only applications.

@roman-right
Copy link
Member

Hi @jorma16 ,
Thank you very much for the PR. THis feature is so reasonable. Could you please add a test for it? It could check if indexes were not created in the db.

Copy link
Contributor

github-actions bot commented Aug 3, 2024

This PR is stale because it has been open 45 days with no activity.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

This PR is stale because it has been open 45 days with no activity.

@jorma16
Copy link
Contributor Author

jorma16 commented Nov 18, 2024

Hi! I couldn't check this PR until today, sorry for the delay.

I have added the tests that you requested, thanks in advance!

Copy link
Member

@adeelsohailahmed adeelsohailahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@adeelsohailahmed adeelsohailahmed requested a review from a team December 1, 2024 23:44
@adeelsohailahmed adeelsohailahmed enabled auto-merge (squash) December 1, 2024 23:47
@adeelsohailahmed adeelsohailahmed requested a review from a team December 3, 2024 04:06
@adeelsohailahmed adeelsohailahmed added enhancement New feature or request and removed action requested labels Dec 3, 2024
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me.

@adeelsohailahmed adeelsohailahmed merged commit 75db4a4 into BeanieODM:main Dec 4, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants