fix(core): keep history state when reloading input

BearToCode · Nov 15, 2023 · b187a6a · b187a6a
1 parent a61e049
commit b187a6a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/carta-md/src/lib/internal/carta.ts b/packages/carta-md/src/lib/internal/carta.ts
@@ -313,7 +313,7 @@ export class Carta {
 	 */
 	public $setInput(textarea: HTMLTextAreaElement, container: HTMLDivElement, callback: () => void) {
 		// Remove old listeners if any
-		this.input?.events.removeEventListener('update', callback);
+		const previousInput = this.input;
 
 		this._input = new CartaInput(textarea, container, {
 			shortcuts: this.keyboardShortcuts,
@@ -322,6 +322,11 @@ export class Carta {
 			historyOpts: this.options?.historyOptions
 		});
 
+		if (previousInput) {
+			previousInput.events.removeEventListener('update', callback);
+			this._input.history = previousInput.history;
+		}
+
 		this._input.events.addEventListener('update', callback);
 
 		// Bind elements

diff --git a/packages/carta-md/src/lib/internal/input.ts b/packages/carta-md/src/lib/internal/input.ts
@@ -30,7 +30,7 @@ export class CartaInput {
 	// Used to detect keys that actually changed the textarea value
 	private onKeyDownValue: string | undefined;
 
-	public readonly history: CartaHistory;
+	public history: CartaHistory;
 	public readonly events = new EventTarget();
 
 	constructor(