Closes 3943 issue with reshape (#3947)

* Ready for testing * Addresses flake8 error --------- Co-authored-by: drculhane <[email protected]> Co-authored-by: ajpotts <[email protected]>
Bears-R-Us · Jan 3, 2025 · fcdd559 · fcdd559
1 parent a77be87
commit fcdd559
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/arkouda/pdarrayclass.py b/arkouda/pdarrayclass.py
@@ -1817,13 +1817,17 @@ def reshape(self, *shape):
         """
         # allows the elements of the shape parameter to be passed in as separate arguments
         # For example, a.reshape(10, 11) is equivalent to a.reshape((10, 11))
+        # the lenshape variable addresses an error that occurred when a single integer was
+        # passed
         if len(shape) == 1:
             shape = shape[0]
-        elif not isinstance(shape, pdarray):
+            lenshape = 1
+        if (not isinstance(shape, int)) and (not isinstance(shape, pdarray)):
             shape = [i for i in shape]
+            lenshape = len(shape)
         return create_pdarray(
             generic_msg(
-                cmd=f"reshape<{self.dtype},{self.ndim},{len(shape)}>",
+                cmd=f"reshape<{self.dtype},{self.ndim},{lenshape}>",
                 args={
                     "name": self.name,
                     "shape": shape,

diff --git a/tests/pdarrayclass_test.py b/tests/pdarrayclass_test.py
@@ -29,6 +29,8 @@ def test_reshape(self, dtype):
         r = a.reshape((2, 2))
         assert r.shape == (2, 2)
         assert isinstance(r, ak.pdarray)
+        b = r.reshape(4)
+        assert ak.all(a==b)
 
     @pytest.mark.skip_if_max_rank_less_than(3)
     def test_reshape_and_flatten_bug_reproducer(self):