Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part 3 of #3933: failing make install-arrow #3946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Part 3 of #3933: failing make install-arrow #3946

wants to merge 1 commit into from

Conversation

ajpotts
Copy link
Contributor

@ajpotts ajpotts commented Dec 16, 2024 •
edited
Loading

This PR separates the arrow install into make install-arrow and make install-arrow-quick. make install-arrow will build from source, whereas install-arrow-quick will build from the .deb or .rpm file, if available.

Part 3 of #3933: failing make install-arrow
Closes #3931, #3933

@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch 4 times, most recently from 2cd4bf1 to 7c8022e Compare December 16, 2024 22:22
@ajpotts ajpotts marked this pull request as ready for review December 16, 2024 22:23
@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch from 7c8022e to 3ddeb6e Compare December 17, 2024 18:19
jaketrookman
jaketrookman approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jaketrookman jaketrookman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch 2 times, most recently from e7d8579 to 80d890a Compare December 18, 2024 21:07
@ajpotts
Copy link
Contributor Author

ajpotts commented Dec 20, 2024

Arrow documentation about offline builds: https://arrow.apache.org/docs/dev/developers/cpp/building.html#offline-builds

@ajpotts ajpotts marked this pull request as draft December 21, 2024 00:19
@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch 7 times, most recently from dc39b22 to b45af35 Compare December 30, 2024 14:59
@ajpotts ajpotts marked this pull request as ready for review December 30, 2024 14:59
@ajpotts
Copy link
Contributor Author

ajpotts commented Dec 30, 2024 •
edited
Loading

To Test the almalinux install without network connection:

  1. Pull the container: docker pull ajpotts/almalinux-with-arkouda-deps:1.0.0
  2. Run the container: docker run -it --network none almalinux-with-arkouda-deps:1.0.0
  3. Test that you will get an error if you try to download from the internet: dnf install gedit
  4. Enter the arkouda directory: cd /root/arkouda/
  5. Build: make install-deps DEP_BUILD_DIR=/dep/build
  6. Make arkouda: make
  7. Verify tests run: make test

@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch 2 times, most recently from 55c2398 to a6c65b0 Compare December 30, 2024 18:43
@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch from 6da79e8 to 1e14a51 Compare January 3, 2025 14:47
@ajpotts ajpotts mentioned this pull request Jan 3, 2025
Draft
@ajpotts ajpotts force-pushed the 3933_failing_make_install-arrow_pt3 branch from 1e14a51 to 3135bd0 Compare January 4, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasslitvinov vasslitvinov vasslitvinov left review comments

@jaketrookman jaketrookman jaketrookman approved these changes

@drculhane drculhane Awaiting requested review from drculhane

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in make install-deps
3 participants
@ajpotts @vasslitvinov @jaketrookman