Closes-4096, adding range parameter to histogram functions
#4078
+252
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasslitvinov
force-pushed
the
histogram-ranges
branch
from
d351696 to
d51dafd
Compare
ajpotts
reviewed
Feb 7, 2025
ajpotts
reviewed
Feb 7, 2025
ajpotts
reviewed
Feb 7, 2025
| @@ -1996,17 +2064,31 @@ def histogramdd( | |||
| if any(b < 1 for b in bins): | |||
| raise ValueError("bins must be 1 or greater") | |||
|
|
|||
| if not range: | |||
| range = [None for pda in sample] | |||
There was a problem hiding this comment.
Right here you allow range to contain the value None.
There was a problem hiding this comment.
I resolved this by introducing a different variable, range2, instead of reusing range for different things.
BTW it turns out the same trick works in the other case with xMin et al. so I applied it there as well by introducing xMin0 et al.
ajpotts
reviewed
Feb 7, 2025
arkouda/numpy/_numeric.py
Outdated
| bin_boundaries = [linspace(a.min(), a.max(), b + 1) for a, b in zip(sample, bins)] | ||
| bins_pda = array(bins)[::-1] | ||
| dim_prod = (cumprod(bins_pda) // bins_pda)[::-1] | ||
| bin_boundaries = [linspace(r[0], r[1], b + 1) for r, b in zip(range, bins)] |
There was a problem hiding this comment.
But down here, the value None is not indexable as r[0] and r[1].
vasslitvinov
force-pushed
the
histogram-ranges
branch
from
b281dc9 to
36a920c
Compare
vasslitvinov
changed the title
range parameter to histogram functionsrange parameter to histogram functions
vasslitvinov
force-pushed
the
histogram-ranges
branch
from
e196fc5 to
0a81945
Compare
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
Signed-off-by: Vassily Litvinov <[email protected]>
vasslitvinov
force-pushed
the
histogram-ranges
branch
from
d541bf8 to
8fd9a7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4096. Required by Bears-R-Us/arkouda-contrib#179
Adds
numpy-style optionalrangeparameter to client histogram functions:histogram()histogram2d()histogramdd()Switches the histograms produced by
histogramdd()to containfloatcounts instead of integer counts, to matchnumpy.While there:
histogramdDMsg()more efficient.histogramdd()oncumprod()./and trailing whitespace.