-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper #158
base: main
Are you sure you want to change the base?
JOSS paper #158
Conversation
(Issue #147)
You can start by updating your author meta data in Follow the examples in the file. |
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=======================================
Coverage 62.63% 62.63%
=======================================
Files 21 21
Lines 4135 4135
Branches 662 662
=======================================
Hits 2590 2590
Misses 1359 1359
Partials 186 186 Continue to review full report at Codecov.
|
I'm a bit worried about the acceptance criteria of JOSS. Even if super convenient, this library is largely a python binding to Gromacs command line interface, and they are somewhat strict about bindings. What do you think? And what about I'm expect to write? Automatic cached documentation generated from the original tools? Was nice to found the performance issue using the profiler, someone with internal knowledge could find intuitively, but for foreigners is easy to find the spot only profiling. |
I would say it pass the criteria because of lots of working knowledge packed in GromacsWrapper. Just by reading the examples was helpful to improve my Gromacs workflows. For example, I'm doing my first membrane simulation and didn't know that was handy to align the membrane on the XY plane with trj_xyfitted. |
Probably its my fault but I was not able to push my meta data to the PR. Are there any things I have to consider? |
Short software paper for submission to the Journal of Open Source Software.
The paper will be part of the GromacsWrapper repository; this appears to be the common pattern with other JOSS papers.
Closes Issue #147 (This branch will be merged when the paper is submitted.)
Author contributions
paper.md
directly on GitHub.