Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDB IGNORE] [RECOUP] [PORT] Removes Auxmos in favour of LINDA #11813

Merged
merged 766 commits into from
Jan 31, 2025

Conversation

XeonMations
Copy link
Contributor

@XeonMations XeonMations commented Oct 31, 2024

About The Pull Request

Number of "What is LINDA" questions post PR publication: 40

This PR is a recoup of #11165 , due to @JixS4v no longer having time, i've taken upon myself to finish jesus's work.

This should update our atmospherics systems to modern TG. If all goes well, that is

Revets: #11274

Ported TG station PRs:

Warning: There are a lot of PRs.

Ports the following Monkestation PRs:

My own edits:

  • Lines 734-770 in gas_mixture.dm
  • Edited some checks in subsystem/air.dm for firelocks and transit space. Fixes them going off whenever a shuttle starts to move.

Why It's Good For The Game

Replacing Auxmos with LINDA would finally remove a major coding debt we've had in the codebase. Also would finally allow us to update to byond 515 and beyond.

Testing Photographs and Procedure

Screenshots&Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 JixS4v, XeonMations, HowToLu, Aramix, 00-Steven, 13spacemen, Aerden, afonamos2, AlinaStarkova, Arkatos1, Ben10Omintrix, BurgerLUA, Comxy, Deadgebert, EliteCreature, EnterTheJake, FlufflesTheDog, Ghilker, GoblinBackwards, GoldenAlpharex, GuillaumePrata, Higgin, JohnFulpWillard, Kylerace, LemonInTheDark, MTandi, MacBlaze1, Mothblocks, OrionTheFox, Pickle-Coding, Putnam3145, RandomGamer123, Sadboysuss, Sealed101, ShizCalev, SuperNovaa41, SyncIt21, Tastyfish, TemporalOroboros, TheBoondock, thegrb93, Timberpoes, TiviPlus, Tlaltecuhtli, TwistedCicrularConvexLens, ZephyrTFA, blessedmulligan, chestlet, esainane, haukeschuemann, jlsnow301, kriskog, lessthnthree, mc-oofert, mogeoko, nicbn, nikothedude, ninjanomnom, norill, skylord-a52, timothymtorres, tralezab, vincentiusvin, zxaber, Absolucy, SergeiKoralev
remove: Removed a deprecated atmospherics system from the game: Auxmos.
add: Added a new atmospheric system to the game: LINDA.
refactor: The majority of atmospherics related systems have been changed. Please report any bugs to the github!
add: Added new functionality to atmospheric pipes.
qol: Air alarms now display the location of the issue.
qol: Air alarms now have AC built into them.
qol: You can now instantly unwrench pipes that have no gases in them.
/:cl:

@JixS4v
Copy link
Contributor

JixS4v commented Oct 31, 2024

Beat of luck with this it took me months to get to where it was and there's probably a few months' work in there remaining. Hope you can find what's wrong with pipenets

@XeonMations XeonMations changed the title [MDB IGNORE] [RECOUP] [PORT] Deprecates AUxmos in favour of LINDA [MDB IGNORE] [RECOUP] [PORT] Deprecates Auxmos in favour of LINDA Oct 31, 2024
@XeonMations
Copy link
Contributor Author

To do:

Test Toxins
Test Fland
Test Supermatter
Test Mass plasmafires
Test Fusion

Make atmos machinery actually work. Such as pipes and valves and filters.

@github-actions github-actions bot added TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Sprites labels Nov 3, 2024
@JixS4v
Copy link
Contributor

JixS4v commented Nov 4, 2024

I see you are coping wtih this properly

Copy link

github-actions bot commented Nov 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@JixS4v
Copy link
Contributor

JixS4v commented Nov 8, 2024

Btw I don't think smart pipes were meant to be ported, you'd probably have to ask bacon

Copy link

github-actions bot commented Nov 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@XeonMations XeonMations changed the title [MDB IGNORE] [RECOUP] [PORT] Deprecates Auxmos in favour of LINDA [MDB IGNORE] [RECOUP] [PORT] Removes Auxmos in favour of LINDA Nov 13, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@XeonMations
Copy link
Contributor Author

To do: Acquire beestation artstyle of canister shielding and canister cell hatch

@XeonMations
Copy link
Contributor Author

All further development switched to byond 515.1646

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@XeonMations
Copy link
Contributor Author

All known bugs are patched, all known issues resolved. LINDA is officially ready for merge. (Unless someone else finds something.)

@Dejaku51
Copy link
Contributor

Fix grrr

image

@XeonMations
Copy link
Contributor Author

Fix grrr

image

Fixed

@PowerfulBacon PowerfulBacon added this pull request to the merge queue Jan 31, 2025
Merged via the queue into BeeStation:master with commit e81d7bc Jan 31, 2025
23 checks passed
@XeonMations XeonMations deleted the Linda-Recoup branch January 31, 2025 17:30
@Tsar-Salat Tsar-Salat removed the Feature Freeze Source The source of a feature freeze label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration Code Improvement Feature GitHub Golden ⭐ For high-effort PRs that make big and good improvements to the game. Mapping DMM Change Needs Testmerge Refactor Sound Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.