Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New silicon emote, slowclap + emotes for MMIs #12043

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

mrmanlikesbt
Copy link
Contributor

@mrmanlikesbt mrmanlikesbt commented Dec 16, 2024

About The Pull Request

Adds a new slowclap emote for silicons.
MMIs can use silicon emotes now

Why It's Good For The Game

Arguably the greatest emote to have ever existed in SS13. Perfect for mocking assistants when they shock themselves

Testing Photographs and Procedure

Screenshots&Videos
2024-12-16.04-00-45.mp4

Changelog

🆑
add: Silicons have a new emote, slowclap
tweak: MMIs can use silicon emotes
/:cl:

@mrmanlikesbt mrmanlikesbt changed the title initial New silicon emote, slowclap Dec 16, 2024
@Therealdoooc213
Copy link
Contributor

Get this guy a good pr label rn

@RDS88-beeman
Copy link
Contributor

can MMIs, carded AIs, and posibrains also get the emote? So we can make the obvious joke when the AI gets put into a intelitater

@Liver-1
Copy link
Contributor

Liver-1 commented Dec 16, 2024

The best PR. Maybe ever?

@Therealdoooc213
Copy link
Contributor

Oh yeah, IPC's should also probably get this emote.

@XeonMations
Copy link
Contributor

Why only for silicons?

@mrmanlikesbt
Copy link
Contributor Author

mrmanlikesbt commented Dec 16, 2024

IPCs can slowclap now. Went ahead and made it so MMIs can use all silicon emotes too

2024-12-16.14-53-39.mp4

@mrmanlikesbt mrmanlikesbt changed the title New silicon emote, slowclap New silicon emote, slowclap + emotes for MMIs Dec 16, 2024
Copy link
Contributor

@ClownMoff ClownMoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird way to word it. Why would borgs have a slow clap processor? Why would a MMI have a slow clap processor? Maybe a synthetizer. But then again, kinda silly emote worded this way. Ideally emotes should be able to be understanded without sound, and the way its currently worded is a little confusing. Also, in my opinion something like "plays a slow clapping sound" is a much more dry and sarcastic statement.

code/modules/mob/living/carbon/human/emote.dm Show resolved Hide resolved
@Sadboysuss
Copy link

mfw there is no attribution to the source of the sound file

@mrmanlikesbt
Copy link
Contributor Author

already in the game files

Copy link
Contributor

@Tsar-Salat Tsar-Salat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Tsar-Salat Tsar-Salat added this pull request to the merge queue Jan 22, 2025
Merged via the queue into BeeStation:master with commit 6c31c96 Jan 22, 2025
21 checks passed
@mrmanlikesbt mrmanlikesbt deleted the slowclap branch January 22, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants