Remove 'context' parameter from TGUIs #12172
Merged
+1,998
−2,078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Most context This is a precursor PR for moving to React. Newer React (>16) does not have the `context` parameter, so it needs removed. I want to make converting to React look slightly less intimidating, so this is just short-circuiting context here. This shouldn't be considered a long term solution. Moving to react is good actually N/A hopefully no noticeable change
In folder: tgui/packages/tgui/interfaces/**
REPLACE: useBackend(<\w+>)?\(([\n ]*?)?(this\.)?context\s?\)
WITH: useBackend$1()
REPLACE: use(Local|Shared)State(<[\S\s]+>)?\(([\n ]*?)?(this\.)?context,? ?
WITH: use$1State$2(
REPLACE: \(([\n ]*?)?((\w+|\{([\S\s]+\}))(: (\w+|\{([\S\s]+\})))?),([\n ]*?)?_?context(: (\w+|\{([\S\s]+\})))?([\n ]*?)?\)
WITH: ($2)
github-actions
bot
added
the
TGUI-Changes
PowerfulBacon
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Had a look at a few UIs and the internal code, relatively simple change. Will this fail status checks if another TGUI window gets merged and hasn't been updated to use context properly? It would be nice to have some kind of static time checks to make sure bad UIs don't get merged, but I'm not sure if we can do that easilly with javascript (maybe the regex you use can be a lint?)
|
JavaScript is difficult to check like that. It'll just be an announcement. Also, my React PR will remove remaining instances. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ports tgstation/tgstation#80003
For maintainers, the best way to review this is to just check the first commit on this PR for the actual technical changes. Everything else is just automatic regex.
Regex For Downstreams
I wrote these myself. They "just work". Don't question it.
In folder:
tgui/packages/tgui/interfaces/**REPLACE:
useBackend(<\w+>)?\(([\n ]*?)?(this\.)?context\s?\)WITH:
useBackend$1()REPLACE:
use(Local|Shared)State(<[\S\s]+>)?\(([\n ]*?)?(this\.)?context,? ?WITH:
use$1State$2(REPLACE:
\(([\n ]*?)?((\w+|\{([\S\s]+\}))(: (\w+|\{([\S\s]+\})))?),([\n ]*?)?_?context(: (\w+|\{([\S\s]+\})))?([\n ]*?)?\)WITH:
($2)How to use
Why It's Good For The Game
This is a precursor for React. The 'context' parameter isn't used in modern React. There's no need to pass it around a bunch.
Testing Photographs and Procedure
Screenshots&Videos
TGUIs work.
Changelog
🆑 itsmeow, jlsnow301
code: Removed 'context' parameter from TGUIs. This is an internal change that should not affect anything.
/:cl: