Fixes bug from juicing bug fix fix fix #12223
Open
+18
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mixing reagents in body works too
|
|
Juicing just won't stop beating us down |
Tsar-Salat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Ok its not really one line, but I forgot to fix the args and add a istypecheck for this proc during juicing.
The 1 line is Switching from round() to FLOOR(), which fixes the rounding during add_reagent with very tiny reagent numbers.
Why It's Good For The Game
No more infinite loop when mixing weird amounts of constituent reagents in a reaction
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_aF9Bg4GvBX.mp4
Changelog
🆑
fix: fixes infinite reagent loops
/:cl: