move death to living #12241
Open
move death to living #12241
+154
−141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerfulBacon
approved these changes
Feb 14, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Simple pr. death() and gib() are no longer on /mob/, they are instead on /mob/living/
Why It's Good For The Game
This is a change that should have been made like 15 years ago lmao.
Ghosts just return and newplayers dont handle these procs at all, so lets just nest them one level.
I ran into this while coding combat mode, and it was annoying, especially when death expects living level vars.
Lets fix it.
Testing Photographs and Procedure
Screenshots&Videos
dreamseeker_UCutgrOD9F.mp4
Changelog
🆑 rkz, mothblocks
code: moved death() to mob/living/, up from mob/
/:cl: