Mentor fixes and TGUIification

[Gilgaxx]

About The Pull Request

Fixes this issue #8150 (the second half, it went stale, but never fixed) where a mentoree who requests an mrat and then clicks on the kick mentor button, the "are you sure" alert would shoup up to the mentor instead of the mentoree by changing a "friend" to "friend.owner" in the alert.

TGUIfies 4 prompts related to mentors (Asking for an Mrat, kicking an mrat from the mentoree perspective, leaving as an mrat from the mentor perspective, the Mrat naming window and the actual mhelps (this used to be bugged)).

Also ACTUALLY brings back the hotpink chat for Msay (#12228 did not fix it)

Why It's Good For The Game

In order:
Fixes a bug, duh. (Mentors shouldn't be like "nuh uh, I'm staying")
TGUI is nicer looking.
I only heard mentors being sad that we lost the hotpink chat.

Testing Photographs and Procedure

Screenshots&Videos

Loaded in with 2 seperate clients to try this out: Asking for an Mrat:

The Mrat naming:

Here is the two clients running at the same time (mentor on the right, mentoree on the left)

Leaving as the mentor is now TGUI:

Kicking the Mrat as the mentoree is now on TGUI and it's on the right client (tabbing out and back in showed that this prompt was on the right client):

The TGUI mhelp (it used to be a tall white box with "Mentorhelp "text"" at the top):

(it still works)

Disabled local_host_rank in the configs, added myself to the mentor.txt and this is the msay chat now:

Changelog

🆑
fix: Mentors can no longer go "nuh uh" when a mentoree tries to kick out their Mrat.
tweak: TGUIfied most mentor related prompts.
tweak: Made Msay for mentors hot pink again!
/:cl:

[Gilgaxx]

@itsmeow I took your review and decided to keep tweaking this PR while I was at it. I ended up TGUIfing the other mentor prompts and also making the mentor chat actually hotpink again. Updated the PR description and name to reflect these changes.
If this is too varied for a PR do let me know!
Oh also the fix I used to make the mhelps themselves TGUI again was a bit bodged, since the code was already there, could you review it to make sure it's all good?

[itsmeow]

Just make sure this is consistent with ahelp. The reason the msg argument exists is so you can type in the chat box instead of clicking the verb

[Gilgaxx]

You know that's a good point, which made me also aware that the ahelp prompt is ALSO broken and not TGUI 😅
I'll try to come up with a way to fix the TGUI while still maintaining the functionality of beng able to type the message in the verb bar (and probably also apply it to ahelp too).

[Gilgaxx]

After some more time spent on this, I've noticed this is a much bigger problem, there is not a single verb on the top right that displays the TGUI on the top right. I'm also not great at coding myself and can't think of a solution that fixes this issue while leaving the funcionality of being able to type the message in the verb bar intact. I'll keep trying, but I'd apriciate some help, or I might be forced to drop this part of the PR, which would be a shame.

[Gilgaxx]

I undid the change to the mentorhelp verb for now, from what I understand, it's a much deeper problem that arises with the ability to type out a message with a verb being tied to the white default popup text prompt showing up. Although I'm now questioning the need to be able to type out in the command bar in the first place. Or perhaps having a workaround like adding an mhelp hotkey like the ahelp works, although I'd need feedback on that.