Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - adding responsiveness #287 #293

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

N-Dijkstra
Copy link

Issue Addressed

Closes #287

Proposed Changes and Benefits

I added responsiveness to mainly the header component, before it was difficult to read on smaller screens since both the text container and the animation container took up quite a lot of room while sharing a small screen. I have now changed the text container into a navigation bar at the top of the page with a hamburger menu whenever the screen width comes below 900 pixels. This gives the animation the full width of the screen making it stand out more again like on larger screens. I also made RandomContributor responsive for smaller screens.

Overall, I think these changes enhance the responsiveness and usability of the application. They make the header adaptable for various screen sizes, improve navigation through a mobile-friendly hamburger menu, and ensure consistency in the visual design with making sure the project title reappeared in the navigation bar. These improvements will enhance the user experience, especially on smaller devices.

Screenshots

image)
image

Notes to Reviewers

No specific notes

Checklist

  • I have thoroughly read and understand The Contribution Guidelines.
  • The title of this PR follows the keyword: brief description of change format, using one of the following keywords:
    • Feature - adds new or amends existing user-facing behavior.
    • Chore - changes that have no user-facing value, refactors, dependency bumps, etc.
    • Fix - bug fixes.
    • Docs - fixing typos and adding new content.
  • I have listed my proposed changes and their benefits.
  • I have linked the corresponding issue in the Issues section.

Copy link

vercel bot commented Oct 12, 2024

@N-Dijkstra is attempting to deploy a commit to the Before I Die Code Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Adding responsiveness
1 participant