Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CodeQL to v3 using default setup #2198

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

Belco90
Copy link
Owner

@Belco90 Belco90 commented Jan 12, 2024

Changes

  • Removes custom setup using v2
  • Set ups CodeQL using default config, which is automatically updated to v3

Context

GitHub announced the deprecation of CodeQL Action v2. Users of code scanning default setup don't have to do anything since it automatically uses v3.

Since we weren't taking advantage of the advanced setup, this PR removes that config in favor of the default one that gets updated and configured automatically.

CleanShot 2024-01-12 at 17 19 07

Tests

I've checked my work by:

  • Adding new tests or adjusting existing tests
  • Testing manually

@Belco90 Belco90 added the chore Changes that affect the build system, CI config or other changes that don't modify src/test f label Jan 12, 2024
@Belco90 Belco90 self-assigned this Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4dbed3b) 82.35% compared to head (8312669) 82.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2198   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files          30       30           
  Lines         289      289           
  Branches       46       46           
=======================================
  Hits          238      238           
  Misses         45       45           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Belco90
Copy link
Owner Author

Belco90 commented Jan 12, 2024

Copy link

cypress bot commented Jan 12, 2024

Passing run #7223 ↗︎

0 7 0 0 Flakiness 0

Details:

null
Project: Octoclairvoyant Webapp Commit: dadb69e736
Status: Passed Duration: 01:30 💡
Started: Jan 12, 2024 4:27 PM Ended: Jan 12, 2024 4:29 PM

Review all test suite changes for PR #2198 ↗︎

@Belco90 Belco90 added this pull request to the merge queue Jan 12, 2024
Merged via the queue into main with commit dadb69e Jan 12, 2024
15 checks passed
@Belco90 Belco90 deleted the remove-custom-codeql-config branch January 12, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that affect the build system, CI config or other changes that don't modify src/test f
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant