Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak on each call #2

Open
wants to merge 1 commit into
base: release/5.2
Choose a base branch
from

Conversation

seraphv3
Copy link

When testing 5.2.x on windows 7 or windows 10, I found memory leaking on each call, which cause the memory of process audiodg.exe to increase slowly, from 10MB to 40MB. After 180 or more calls, mAudioClient->Initialize() fails with result code 8890017 or 8007000e. If continue with calling, linphone may crash finally. The modified code fixed the memory leak problem. After fixing, 2000 calls do not increase the audiodg.exe memory more than 1MB, and no failing result code when mAudioClient->Initialize().

@Ledjlale
Copy link
Contributor

Hi, thanks for your pull request.
It has been already fixed in 5.3 ;)
https://github.com/BelledonneCommunications/mswasapi/blob/release/5.3/mswasapi_writer.cpp#L147

@seraphv3
Copy link
Author

Oh I didn't notice 5.3 version has fixed. I tried linphone-sdk 5.3 and corresponding linphone-desktop on win7, and found it had no input and output sound. Sdk 5.2 is ok. So I give up using 5.3 and use 5.2 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants