-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant check #253
Conversation
current extraction: (** val read_nf_impl : nat -> domain_nf -> nf **)
let rec read_nf_impl s = function
| D_dom (d0, d1) ->
(match d0 with
| D_nat ->
(match d1 with
| D_zero -> Nf_zero
| D_succ d2 -> Nf_succ (read_nf_impl s (D_dom (D_nat, d2)))
| D_neut (_, d2) -> Nf_neut (read_ne_impl s d2)
| _ -> assert false (* absurd case *))
| ... the type annotation is safe to ignore for the neutral case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the above comment, LGTM.
Not sure. Does it do u shelve? I don't even know when this unresolved goal is coming from.
Thanks,
Jason Hu
…________________________________
From: Ailrun ***@***.***>
Sent: Wednesday, October 16, 2024 4:49:09 PM
To: Beluga-lang/McLTT ***@***.***>
Cc: Jason Hu ***@***.***>; Author ***@***.***>
Subject: Re: [Beluga-lang/McLTT] remove redundant check (PR #253)
@Ailrun approved this pull request.
Other than the above comment, LGTM.
—
Reply to this email directly, view it on GitHub<#253 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABORVT6SK5UJAEBV6CGS4KLZ33GMLAVCNFSM6AAAAABQCHNL3SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZTGY2TINJZGY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
It solves shelved goals as well, so it should work if it is generated because of the universe of Nat. |
it's not really about universe levels. It asks for a |
Closes #252