Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantics for prop eq #254

Merged
merged 4 commits into from
Oct 20, 2024
Merged

Add semantics for prop eq #254

merged 4 commits into from
Oct 20, 2024

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented Oct 18, 2024

No description provided.

@Ailrun Ailrun requested a review from HuStmpHrrr October 18, 2024 18:47
@Ailrun

This comment was marked as resolved.

@HuStmpHrrr

This comment was marked as resolved.

@HuStmpHrrr
Copy link
Member

let's do rebase for PRs going to ext/ branches. better to keep more detailed history for big changes like this.

@Ailrun
Copy link
Member Author

Ailrun commented Oct 18, 2024

@HuStmpHrrr

let's do rebase for PRs going to ext/ branches. better to keep more detailed history for big changes like this.

TBH, I don't see why this PR is big. This PR makes small changes here and there, but there's no huge change (or adding much proofs).

@HuStmpHrrr
Copy link
Member

@HuStmpHrrr

let's do rebase for PRs going to ext/ branches. better to keep more detailed history for big changes like this.

TBH, I don't see why this PR is big. This PR makes small changes here and there, but there's no huge change (or adding much proofs).

ok i see there are only two commits. makes sense then.

@Ailrun Ailrun force-pushed the pr-prop-eq-semantic branch from c7d02c5 to 2e8375c Compare October 20, 2024 07:00
@Ailrun Ailrun enabled auto-merge (squash) October 20, 2024 07:01
@Ailrun Ailrun merged commit 4072e80 into ext/prop-eq Oct 20, 2024
2 checks passed
@Ailrun Ailrun deleted the pr-prop-eq-semantic branch October 20, 2024 07:05
@HuStmpHrrr HuStmpHrrr mentioned this pull request Oct 24, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants