Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cases for completeness #88

Merged
merged 8 commits into from
May 23, 2024
Merged

More cases for completeness #88

merged 8 commits into from
May 23, 2024

Conversation

Ailrun
Copy link
Member

@Ailrun Ailrun commented May 21, 2024

Related: #87

Context, substitution, and variable cases are all done.
Now it's only natural number cases (which are most tedious and complex...)

However, I realized that the natural number cases requires a "stronger" functionality of eval (i.e. functionality modulo equivalence of environment), so I decided to make a separate PR after this.

@Ailrun Ailrun changed the title [WIP] Finish completeness More cases for completeness May 22, 2024
@Ailrun Ailrun mentioned this pull request May 22, 2024
8 tasks
@Ailrun Ailrun requested a review from HuStmpHrrr May 22, 2024 20:41
@Ailrun Ailrun force-pushed the pr-completeness branch from 530f72f to b6e0618 Compare May 22, 2024 20:56
@Ailrun
Copy link
Member Author

Ailrun commented May 23, 2024

However, I realized that the natural number cases requires a "stronger" functionality of eval (i.e. functionality modulo equivalence of environment), so I decided to make a separate PR after this.

Actually, this stronger functionality is not true (because of the Π a p B case which contains p). Maybe we need to bring functional extensionality again here to compare ps.

@Ailrun
Copy link
Member Author

Ailrun commented May 23, 2024

Or we can define a weaker notion of equality between two domain values so that it compares that kind of environment occurence in a pointwise manner.

@HuStmpHrrr
Copy link
Member

where do we need to compare environments? I don't think we need that in Agda

@HuStmpHrrr
Copy link
Member

Or we can define a weaker notion of equality between two domain values so that it compares that kind of environment occurence in a pointwise manner.

I wouldn't say this is a good idea. This will make the model tremendously difficult to work with.

@Ailrun
Copy link
Member Author

Ailrun commented May 23, 2024

Now I think about it, maybe they are definitionally equal. The target was drop_env (p \mapsto a \mapsto b) and p \mapsto a if I remember correctly. (I hope it's not the other way around, i.e. dropping first and adding the top member)

@HuStmpHrrr
Copy link
Member

Now I think about it, maybe they are definitionally equal. The target was drop_env (p \mapsto a \mapsto b) and p \mapsto a if I remember correctly. (I hope it's not the other way around, i.e. dropping first and adding the top member)

It should be this way. There is no essential need for functional extensionality in the Agda code.

@Ailrun
Copy link
Member Author

Ailrun commented May 23, 2024

Yeah, anyway, let's pass this PR first and then finish those few natrec cases in a separate PR as this one is already quite big.

@HuStmpHrrr HuStmpHrrr merged commit 1f26aef into main May 23, 2024
2 checks passed
@Ailrun Ailrun deleted the pr-completeness branch May 24, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants