Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make status check case insensitive #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make status check case insensitive #21

wants to merge 1 commit into from

Conversation

agrrh
Copy link
Contributor

@agrrh agrrh commented Feb 17, 2018

No description provided.

@agrrh agrrh mentioned this pull request Feb 17, 2018
Open
@jvanasco
Copy link

Yeah, I had seen that in the source:

Line 214 also has this:

        results[check_result.attrib['Domain']] = check_result.attrib['Available'] == 'true'

it might be better as:

        results[check_result.attrib['Domain']] = check_result.attrib['Available'].lower() == 'true'

I don't know how stable this particular endpoint or true is, but I've seen False and false in the same domain_info response as attributes to different xml nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrrh @jvanasco