MATCH-V4 being deprecated on June 14th --> migrate to V5

[selmaohneh]

The MATCH-V4 endpoint will be deprecated on June 14th, see here:

https://developer.riotgames.com/apis#match-v4

What's the plan for migrating to V5? How and when will this happen?

[BenFradet]

Hello, the plan is: someone needs to write support for the v5 api

[xXLAOKOONXx]

Heyho,
I had the time to write support for v5 API: https://github.com/xXLaokoonXx/RiotSharp/commit/dc14f21f27e2d08109fc565e1eb885d5e5380d8a

But I am not sure about the dependencies inside the project.
The TournamentRiotApi uses some of the models I modified for Match-V5:

RiotSharp/RiotSharp/TournamentRiotApi.cs

Line 225 in 573b79c

public async Task<MatchDetail> GetTournamentMatchAsync(Region region, long matchId, string tournamentCode,

I am not into the tournament apis at all, so I have little to no knowldege on whether those sections are actually supported right now or not. And it seems I am not able to do proper requests to test either. How should we proceed?

EDIT: I did not touch the testing at all.

[BenFradet]

can we have different models for now?

[xXLAOKOONXx]

Alright, I will copy all the old match models into the tournament endpoint.
Additionally I just realized the timeline model changed as well, i ll start on that as well.

[selmaohneh]

how is the release process? will this be available from nuget? can i somehow help?

[BenFradet]

nuget publishing is currently broken and we'd need someone to take it over. In the meantime you'll need to build from source

[selmaohneh]

nuget publishing is broken? you mean automatic publishing?

how update releasing the nuget package manually for this huge change? i could create the nuget package for you and you put it on nuget.org? v5.0.0?

[BenFradet]

that could work, feel free to open a PR to update the version 👍

[AoshiW]

Personally, I wouldn't release the full version of the library yet, but some alpha/beta versions may be fine.

1. RateLimitedRequester does not support header parameters (prevent incompatible API changes in the future)
2. Tuxedo talked about some new endpoint that will contain timestamps and replace the old endpoint to get a matchIDs

Changing the framework to .NET core 3.1 would be a great change.

[selmaohneh]

i am fine with 5.0.0-alpha as well. as long as it as available from nuget.org im happy. what do you prefer @BenFradet ?

[selmaohneh]

I made a wild guess: #687