Add MATCH-V5 Support

[xXLAOKOONXx]

This Pull request adds support for MATCH-V5:

• Matches by Puuid
• Match by MatchId
• Timeline by MatchId

Additionally the functionalities of the Tournament API should be unchanged. (But the Namespace for the returned Models changed)

This Pull request does not include any changes towards testing. I just have a 'worked on my machine'.

Furthermore there could be some improvement done in regards of some of the values. I did not create any new enum type. I might used a few too often times 'long' instead of 'int'. Documentation from Riot is not there yet, so there is some guessing involved.

Ticket #684

[xXLAOKOONXx]

Information from Riot:

match-v4 is being deprecated on June 14th, 2021. Please use match-v5 as a replacement. match-v5 is available on Development API keys as of April 14th, production access will follow in the coming weeks/month.

The match and timeline responses are not 100% locked. There may be minor field changes, which will be documented in the method details. We'll make our best effort to extend the deprecation window if any changes happen after match-v5 becomes available for production API keys.

https://developer.riotgames.com/apis#match-v5

[xXLAOKOONXx]

I did not validate if tournament api is still working as I can not test this!

[BenFradet]

Thanks a lot, that looks good to me 👍

That PR makes me wonder if we should ditch tournament support, wdyt?

[xXLAOKOONXx]

On twitter riot gave some information on theire plans: https://twitter.com/RiotGamesDevRel/status/1395091864408129536

"We're actively working on solutions to ensure continued support for tournament codes [...]"
so there might be an update in that regards in near future.

I do not understand the current Implementation of the tournament match portion. I found a url snippet that is used but I can not relate it to any current API provided:

RiotSharp/RiotSharp/TournamentRiotApi.cs

Line 33 in 573b79c

private const string MatchRootUrl = "/api/lol/{0}/v2.2/match";

So it might already be the case that there is no support for getting tournament match information (getting codes etc looked fine).

My proposal is to keep the tournament api as is and once Riot adds a new requesturl for tournament matches this requesturl should be implemented in the regarding endpoint (most likely MatchEndpoint) and not costum crafted into the TournamentRiotApi class.

Another option would be to dump all tournament support. This would clearify the identity of RiotSharp from 'reflecting riot apis' towards 'making data from riot apis available', which is what most framework users are here for, i guess. For this decision I do not have an insight in whether the tournament part is actually in use by someone.

[BenFradet]

My proposal is to keep the tournament api as is and once Riot adds a new requesturl for tournament matches this requesturl should be implemented in the regarding endpoint (most likely MatchEndpoint) and not costum crafted into the TournamentRiotApi class.

I think that makes the most sense for now, thank you for the investigation 👍

[selmaohneh]

any news here? can this be merged?

[BenFradet]

I was waiting on @JanOuborny 's review but we can merge now