fix: AppBio Quantstudio - remove omitted wells from calculated data d…

…ocument data sources (#717)
Benchling-Open-Source · Oct 11, 2024 · a2eb8fe · a2eb8fe
1 parent dcf20d4
commit a2eb8fe
Show file tree

Hide file tree

Showing 3 changed files with 106 additions and 481 deletions.
diff --git a/src/allotropy/parsers/appbio_quantstudio/appbio_quantstudio_calculated_documents.py b/src/allotropy/parsers/appbio_quantstudio/appbio_quantstudio_calculated_documents.py
@@ -605,9 +605,6 @@ def iter_comparative_ct_calc_docs(
     calc_docs: list[CalculatedDocument | None] = []
     for sample, target in view_st_data.iter_keys():
         for well_item in view_st_data.get_leaf_item(sample, target):
-            if not well_item.has_result:
-                continue
-
             calc_docs.append(build_quantity(view_tr_data, target, well_item))
             calc_docs.append(build_amp_score(well_item))
             calc_docs.append(build_cq_conf(well_item))
@@ -639,9 +636,6 @@ def iter_standard_curve_calc_docs(
     calc_docs: list[CalculatedDocument | None] = []
     for sample, target in view_st_data.iter_keys():
         for well_item in view_st_data.get_leaf_item(sample, target):
-            if not well_item.has_result:
-                continue
-
             calc_docs.append(build_quantity(view_tr_data, target, well_item))
             calc_docs.append(build_amp_score(well_item))
             calc_docs.append(build_cq_conf(well_item))
@@ -672,9 +666,6 @@ def iter_relative_standard_curve_calc_docs(
     calc_docs: list[CalculatedDocument | None] = []
     for sample, target in view_st_data.iter_keys():
         for well_item in view_st_data.get_leaf_item(sample, target):
-            if not well_item.has_result:
-                continue
-
             calc_docs.append(build_quantity(view_tr_data, target, well_item))
             calc_docs.append(build_amp_score(well_item))
             calc_docs.append(build_cq_conf(well_item))
@@ -708,9 +699,6 @@ def iter_presence_absence_calc_docs(
     calc_docs: list[CalculatedDocument | None] = []
     for sample, target in view_data.iter_keys():
         for well_item in view_data.get_leaf_item(sample, target):
-            if not well_item.has_result:
-                continue
-
             calc_docs.append(build_quantity(None, target, well_item))
             calc_docs.append(build_amp_score(well_item))
             calc_docs.append(build_cq_conf(well_item))
@@ -727,6 +715,7 @@ def iter_calculated_data_documents(
     r_sample: str | None,
     r_target: str | None,
 ) -> Iterator[CalculatedDocument]:
+    well_items = [well_item for well_item in well_items if well_item.has_result]
     view_st = SampleView(sub_view=TargetView())
     view_st_data = view_st.apply(well_items)