Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: luminex xponent adapter #255

Merged
merged 38 commits into from
Jan 30, 2024
Merged

Feat: luminex xponent adapter #255

merged 38 commits into from
Jan 30, 2024

Conversation

slopez-b
Copy link
Collaborator

Add Luminex Xponent support.

@slopez-b
luminex Header strucutre
8647ca6
@slopez-b
complete header tests and validations
e255d70
@slopez-b
add calibration data
87e5745
@slopez-b
add minimum bead count setting to Data
21c5ea7
@slopez-b
better testing for calibration data
fedb281
@slopez-b
variable name
28406a2
@slopez-b
add software version to header
2aa848a
@slopez-b
fix repeated test name
d5d50dc
@slopez-b
run linter check
4135afc
@slopez-b
Merge branch 'main' into slopez/luminex-xponent-adapter
6681877
@slopez-b
rename sample_volume_setting
3e81bca
@slopez-b
fix typo in schema for detector_gain_setting
d39947e
@slopez-b
get only the scalar from sample volume
78ee02b
@slopez-b
measurement list initial
5c0221e
@slopez-b
Merge branch 'main' into slopez/luminex-xponent-adapter
a7bc3b4
@slopez-b
complete measurement structure
9072b7a
@slopez-b
add analytes to measurements
804278f
@slopez-b
allow lines reader header attr to receive valid options
26418aa
@slopez-b
more readable comprehension
1a3a385
@slopez-b
improve error handling
e630145
@slopez-b
add measurement list tests
9a1e2b8
@slopez-b
fix typo in multi analyte profiling schema
8e02973
@slopez-b
add luminex xponent parser
4b4d22e
@slopez-b slopez-b requested a review from a team as a code owner January 26, 2024 15:57
@slopez-b slopez-b marked this pull request as draft January 26, 2024 16:05
@bdworth bdworth removed the request for review from a team January 26, 2024 18:12
@slopez-b slopez-b marked this pull request as ready for review January 26, 2024 19:23
@slopez-b slopez-b force-pushed the slopez/luminex-xponent-adapter branch from 011978c to afec0f6 Compare January 26, 2024 21:10
bdworth
bdworth suggested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@bdworth bdworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm, but a few comments

src/allotropy/parsers/luminex_xponent/luminex_xponent_parser.py Outdated Show resolved Hide resolved
src/allotropy/parsers/luminex_xponent/luminex_xponent_structure.py Outdated Show resolved Hide resolved
src/allotropy/parsers/luminex_xponent/luminex_xponent_structure.py Outdated Show resolved Hide resolved
src/allotropy/parsers/luminex_xponent/luminex_xponent_structure.py Outdated Show resolved Hide resolved
src/allotropy/parsers/luminex_xponent/luminex_xponent_structure.py Outdated Show resolved Hide resolved
tests/parsers/luminex_xponent/luminex_xponent_data.py Outdated Show resolved Hide resolved
tests/parsers/luminex_xponent/luminex_xponent_structure_test.py Outdated Show resolved Hide resolved
tests/parsers/luminex_xponent/luminex_xponent_structure_test.py Outdated Show resolved Hide resolved
tests/parsers/luminex_xponent/luminex_xponent_parser_test.py Outdated Show resolved Hide resolved
tests/parsers/test_utils.py Outdated Show resolved Hide resolved
@slopez-b slopez-b requested a review from bdworth January 30, 2024 15:14
bdworth
bdworth approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@bdworth bdworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

nathan-stender
nathan-stender approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@nathan-stender nathan-stender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks

@slopez-b slopez-b merged commit 2ab4e76 into main Jan 30, 2024
3 checks passed
@slopez-b slopez-b deleted the slopez/luminex-xponent-adapter branch January 30, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdworth bdworth bdworth approved these changes

@nathan-stender nathan-stender nathan-stender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slopez-b @bdworth @nathan-stender