Use TimestampParser in Gen5 PlateNumber #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-number-timestamp-parser Conflicts: tests/parsers/agilent_gen5/plate_number_test.py
Conflicts: CHANGELOG.md
Signed-off-by: Brian Worth <[email protected]>
nathan-stender
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant and buggy date parsing. This gets passed up to use
VendorParser._get_date_timealready.Note that DTZ007 is not a great warning to suppress:
https://docs.astral.sh/ruff/rules/call-datetime-strptime-without-zone/
Tested via a new integration test that [simply removes a " PM" from a time and] fails without the source changes.
Added a TODO noting that TimestampParser doesn't handle localization. Falling back to use it means that it's possible a date/time string that would error before because it didn't match the current mm/dd hardcoded format will not error now whereas it would have before. -- e.g., "01/02/2024" will parse as "2024-01-02" even if it came from a locale using dd/mm formatting. Improving TimestampParser is out of scope now though.