refactor: add PharmSpec structure module #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayaankha-tara
previously requested changes
Jun 10, 2024
src/allotropy/parsers/beckman_pharmspec/beckman_pharmspec_structure.py
Outdated
Show resolved
Hide resolved
nathan-stender
requested changes
Jun 10, 2024
src/allotropy/parsers/beckman_pharmspec/beckman_pharmspec_parser.py
Outdated
Show resolved
Hide resolved
chrisfriedline-benchling
changed the title
chrisfriedline-benchling
changed the title
nathan-stender
previously approved these changes
Jun 24, 2024
Signed-off-by: Nathan Stender <[email protected]>
Signed-off-by: Nathan Stender <[email protected]>
nathan-stender
approved these changes
Jul 11, 2024
mdlu
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a structure module to separate concerns from the parser. This also caused some reordering in the resulting test file.