Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AppBio Quantstudio - support skipping wells that have no results in the raw data file, indicating an omitted well #689

Merged
merged 15 commits into from
Oct 8, 2024

Conversation

nathan-stender
Copy link
Collaborator

No description provided.

@nathan-stender nathan-stender marked this pull request as ready for review October 8, 2024 13:59
@nathan-stender nathan-stender changed the title fix: AppBio Quantstudio - omit wells that have no results in the raw data file, indicating an omitted well feat: AppBio Quantstudio - omit wells that have no results in the raw data file, indicating an omitted well Oct 8, 2024
@nathan-stender nathan-stender changed the title feat: AppBio Quantstudio - omit wells that have no results in the raw data file, indicating an omitted well feat: AppBio Quantstudio - support skipping wells that have no results in the raw data file, indicating an omitted well Oct 8, 2024
Copy link
Collaborator

@mdlu mdlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm that the desired behavior is to entirely skip wells without results, rather than adding some sort of "placeholder value" indicating it was without results? (getting flashbacks to my recent empty wells lookup config ticket haha)

@nathan-stender
Copy link
Collaborator Author

@mdlu yeah that's the approach we're taking right now. Might figure out a way to support empty well metadata in the future, but for now we just want to unblock customers with this use case.

@nathan-stender nathan-stender merged commit 01c291a into main Oct 8, 2024
5 checks passed
@nathan-stender nathan-stender deleted the nstender-omitted-wells branch October 8, 2024 15:12
nathan-stender added a commit that referenced this pull request Oct 9, 2024
### Added

- Revvity Kaleido - add v3.5 to supported software versions (#707)
- Add new REC chema for solution analyzer 2024/09 (#706)
- AppBio Quantstudio - support skipping wells that have no results in
the raw data file, indicating an omitted well (#689)
- AppBio Quantstudio - add "quantity" calculated data documents for
non-STANDARD wells (#698)
- Update adapters using 2024/06 Plate Reader schema to include ASM file
identifier (#695)
- NanoDrop 8000 & NanoDrop Eight - support alternative reporting format
for absorbance measurements (#688)
- Add support for error documents in the Agilent Gen5 adapter (#694)
- Add the REC/2024/06 electrophoresis schema (#693)
- Update Methodical Mind adapter to use REC schema (#692)
- Update Methodical Mind to use the plate reader REC schema (#690)
- Agilent Gen5 Image adapter, add support for no result sections file
examples (#679)
- ThermoSkanIt Adapter (#658)
- Perkin Elmer Envision - Update adapter to use Plate Reader REC 2024/06
schema (#686)
- BMG Mars - Update adapter to Plate Reader REC 2024/06 schema (#685)
- Add REC/2024/06 spectrophotometry schema (#684)
- Add Nanodrop Eight parser (#683)
- Unchained Labs Lunatic - add additional metadata from header block
(#680)

### Fixed

- SoftMax Pro - raise error for unsupported Group data format (#696)
- Agilent Gen5 - raise error when there are calculated data but no
measurements in results (#691)
- Beckman VI-Cell Blu - filter NaN values when reading cell counts
(#687)
- Update DataSeries to use float parsing utility when reading a float
value, in order to better handle edge cases (#682)

### Changed

- ThermoFisher Qubit Flex - refactor parser to use schema mapper design
pattern (#699)
- Change the way custom information is organized in schema mappers and
ASM outputs to be consistent with future expectations of ASM (#673)
- Rebrand nanodrop eight adapter to nanodrop 8000 (#652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants